Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on data flow does not open it in properties #785

Closed
jbaptistemariebio opened this issue Nov 15, 2023 · 6 comments · Fixed by #1099
Closed

Clicking on data flow does not open it in properties #785

jbaptistemariebio opened this issue Nov 15, 2023 · 6 comments · Fixed by #1099

Comments

@jbaptistemariebio
Copy link

jbaptistemariebio commented Nov 15, 2023

Describe the bug:
Clicking on an existing data flow does not set its properties into the properties section. A double click is needed, but it results in an addition of a new point on the data flow.

Expected behaviour:
A single click on the data flow makes its properties accessible in the properties section

Environment:

  • Version: 2.1.1
  • Platform: Desktop App and Web App
  • OS: MAC OS / Windows / Linux
  • Browser: All

To Reproduce:

  1. Add a data flow
  2. Select another component on the diagram
  3. Click on the data flow just created
@jbaptistemariebio jbaptistemariebio added the bug Something isn't working label Nov 15, 2023
@jgadsden
Copy link
Collaborator

I understand the frustration @jbaptistemariebio , but this is the behaviour inherited from the drawing package and can not be changed. If you need to select with a single click then use the end points of the dataflow and click on either of them

@jgadsden
Copy link
Collaborator

We can try and improve the documentation to emphasise this behaviour, given that there is not much we can do about it

@jgadsden jgadsden added documentation Improvements or additions to documentation priority version-2.1 and removed bug Something isn't working labels Nov 17, 2023
@jgadsden jgadsden self-assigned this Nov 23, 2023
@hilari0n
Copy link

I'm on Windows, on Threat Dragon (desktop app) 2.1.3.0 and have the same issue.
The workaround to click on the end point does not work for all data flows. I.e. if an end of the data flow is attached to a process, then clicking at the end of the data flow attached to it is not possible - the process gets selected. So if both ends of a data flow are attached to a process, you can't access properties by a simple single-click.
Is there an alternative to "select with a single click"? I.e., I don't need this to be a single click, I just need a working way to access the properties and threats of a data flow. (I tried the "Tab" key, right-click, double-click.)

And just before posting this I accidentally stumbled upon a workaround to the workaround. I.e., if your data flow ends are tied to a process, and you can't simply click the end of the data flow, because it selects the process, the solution may be (works for me, at least for the couple of cases I tested) to first hover the mouse cursor over the data flow, for it's boundary box to appear, and then carefully move the cursor along the data flow until its end (making sure not to leave the boundary box), i.e., until the cursor changes (to show, that you can grab and move the ending point) and then click it. It may not be trivial, if the data flow line area between the processes is small. You can use zoom in, to make it a bit easier.

@jgadsden jgadsden modified the milestones: Version 2.2, Version 2.3 Mar 23, 2024
@jgadsden jgadsden changed the title On MAC OS, clicking on data flow does not open it in properties Clicking on data flow does not open it in properties Jul 20, 2024
@MaSven
Copy link

MaSven commented Aug 9, 2024

Would it help to have a list of the objects on the side? At least this would make it possible the edit them from there.

@jgadsden
Copy link
Collaborator

jgadsden commented Aug 9, 2024

will have another attempt at improving the selectability of the dataflows and trust boundaries

@jgadsden
Copy link
Collaborator

jgadsden commented Oct 5, 2024

This is fixed in pull request 'Migrate to version 2.x antv/x6' #1099, where the selection of dataflows and trust boundary curves is greatly improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants