Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User option to increase max file size upload #236

Closed
sambles opened this issue Nov 5, 2020 · 0 comments · Fixed by #238
Closed

User option to increase max file size upload #236

sambles opened this issue Nov 5, 2020 · 0 comments · Fixed by #238
Assignees

Comments

@sambles
Copy link
Contributor

sambles commented Nov 5, 2020

https://github.com/OasisLMF/OasisUI/blob/master/BFE_RShiny/oasisui/inst/app/global.R#L8

Roland I think there shouldn't be any general issue with increasing the limit, although such large file sizes are probably not very common and tested.
There are however a few other things to consider if you would like to have an ENV var, to be sure that the same limit is supported throughout the whole platform. E.g. there is this https://www.shinyproxy.io/configuration/#uploading-large-files, which I am not sure whether it affects you. And there could be other settings in other components that you would probably be more aware of than me.
In addition, you may want to test and benchmark some upload speeds. It will typically vary a lot across browsers (and types of servers, but that's fixed anyhow). Plus we are still running on package versions as of Dec 2018, and for example last year there have been issues with large file uploads being slow - not sure if we'd be affected - which seem sorted out meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant