Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_Layout not displayed in .Net core 2.0 preview 1 #16

Closed
Ponant opened this issue Jun 26, 2017 · 6 comments
Closed

_Layout not displayed in .Net core 2.0 preview 1 #16

Ponant opened this issue Jun 26, 2017 · 6 comments

Comments

@Ponant
Copy link

Ponant commented Jun 26, 2017

Hi @OdeToCode ,
Did you encounter a bug with the FeaturesFolder with .Net Core 2.0 Preview 1? I was working without issues on .Net Core 1.1 with your routine and the views were properly discovered, but now starting with an empty template in preview 1 and adding a home/index view with a controller and attribute routing and a shared layout view gets the latter not displayed by a browser. The only way to have it read is to invoke Layout = "_Layout"; directly from Home Index view.

@OdeToCode
Copy link
Owner

Good question, I haven't tried this package with 2.0 myself, was waiting for it to get a bit closer to a release candidate status.

@Ponant
Copy link
Author

Ponant commented Jun 26, 2017

Unfortunately, I confirm the existence of this bug as I took a fresh new template and added your nuget. If you have an idea on what I should look for I would be happy to tackle it. I get the following warning, not sure if this is related.
Microsoft.IdentityModel.Clients.ActiveDirectory 3.13.5 depends on System.Net.Http (>= 4.0.1) but System.Net.Http 4.0.1 was not found. An approximate best match of System.Net.Http 4.1.0 was resolved.

@OdeToCode
Copy link
Owner

Does the empty template include a _viewstart file?

@Ponant
Copy link
Author

Ponant commented Jun 26, 2017

No, it's empty as before. Of course I added the _ViewStart.cshtml

@Ponant
Copy link
Author

Ponant commented Jun 26, 2017

Here is a repro
https://github.com/Ponant/LayoutFeature and discussion here
aspnet/Mvc#6448

@Ponant
Copy link
Author

Ponant commented Jun 27, 2017

@OdeToCode , the workaround is now on the aspnet/mvc repo. It is not due to your package. Wise to wait for the official release.
aspnet/Mvc#6448

@Ponant Ponant closed this as completed Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants