Fix comment fetch when pinned count == page count #3033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Ticket 3032 ## Remarks The removed line doesn't belong in that effect because comment-fetching has always been a function of scroll position and 'current vs total page count'. But I'm sure it's there for an documented reason. Couldn't figure out from history, so we'll have to try out random cases (e.g. pop out? livestream?)
Digging a bit further, one potential scenario is the one above, although I couldn't replicate any odd behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #3032
Remarks
The line doesn't belong in that effect because comment-fetching has always been a function of scroll position and 'current vs total page count'.
But I'm sure it's there for a reason. Couldn't figure out from history either, so we'll have to try out random cases (e.g. pop out? livestream?). Help @
infto see what breaks?