Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CRA with Vite or similar for NodeJS templates. #11262

Open
rogersau opened this issue Apr 3, 2024 · 5 comments
Open

Replace CRA with Vite or similar for NodeJS templates. #11262

rogersau opened this issue Apr 3, 2024 · 5 comments
Assignees
Labels
feature-request The issue is a feature request TA:PM PM investigation area
Milestone

Comments

@rogersau
Copy link

rogersau commented Apr 3, 2024

Is your feature request related to a problem? Please describe.

The React with Fluent UI template utilizes react-scripts (CRA) as its tooling. This results in extremely slow debugging and hot reloads. resulting in a poor developer experience. I find myself often using the template the stripping out react-scripts and moving to vite.

I believe ensuring a rock-solid foundation for Teams App development will lower the barrier of entry for new developers looking to extend functionality within Microsoft Teams. It will also ensure organizations do not start their journey already with Tech debt in their stack.

Describe the solution you'd like

  • Investigate utilizing Vite (or similar) to speed up debug and modernize building of the application.

Describe alternatives you've considered

  • Vite seems the most logical and simple replacement, it is recommended by the react.dev team.
  • Parcel is another option, less familiar myself with it.
  • Another option potentially could be remix/next.js however they probably are overkill.

Additional context

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Apr 3, 2024
@adashen adashen added feature-request The issue is a feature request TA:PM PM investigation area labels Apr 3, 2024
@summzhan
Copy link
Contributor

Hi @rogersau Thanks for this feedback, which is very valuable to us, but we need to discuss internally cause we have partner dependency on the SDKs we used, will keep you informed if we are going to make improvement in future release.

@adashen adashen removed the needs attention This issue needs the attention of a contributor. label Apr 13, 2024
@Ali-Milani-13 Ali-Milani-13 mentioned this issue May 23, 2024
Closed
@ThomasPe
Copy link

ThomasPe commented Oct 8, 2024

@rogersau do you happen to have a guide on how to switch from CRA to vite?

btw. there seems to be at least some movement on that issue:
https://github.com/search?q=repo%3AOfficeDev%2Fteams-toolkit%20vite&type=code

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Oct 8, 2024
@summzhan summzhan removed the needs attention This issue needs the attention of a contributor. label Oct 23, 2024
@Yimin-Jin
Copy link
Contributor

We have already migrated the Tab Dashboard template from CRA to Vite in the pre-release v5.10.0 version. In future releases, we plan to migrate more templates and samples to Vite to enhance the development experience.

@ThomasPe
Copy link

thats great to see. Are you planning on migrating existing projects to vite with a future Teams Toolkit update or will this always be a manual upgrade for existing proujects?

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Oct 28, 2024
@Yimin-Jin
Copy link
Contributor

We are in the process of migrating all templates in the Teams Toolkit (TTK) from CRA to Vite. In future updates, you won't need to manually upgrade your existing projects. Instead, you will be able to scaffold the latest templates directly from TTK.

@adashen adashen removed the needs attention This issue needs the attention of a contributor. label Oct 29, 2024
@adashen adashen added this to the Backlog milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request The issue is a feature request TA:PM PM investigation area
Projects
None yet
Development

No branches or pull requests

5 participants