Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the SMS provider #6

Closed
JeffreyPerplex opened this issue May 26, 2017 · 2 comments
Closed

Implement the SMS provider #6

JeffreyPerplex opened this issue May 26, 2017 · 2 comments
Labels

Comments

@JeffreyPerplex
Copy link

I tried to register my own SMS Provider. I will sent a Pull Request later on, when I've got it to work, but for now the implementation is hidden in an internal class.

I've implemented your BaseSMSPRovider-class with the following code:

`using PerplexLibSMS.Interfaces;
using PerplexLibSMS.SMSApis;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;

namespace _2FA.Code
{
public class TwoFactorSMSPerplexProvider : Orc.Fortress.SMSProvider.BaseSMSProvider
{
public override void SendSms(string number, string message)
{
ISMSApi api = new CMProvider();
api.From = "+31263830734";
api.To = new List() {number};
var result = api.Send(message);

    }
}

}`

But then what? I expected that maybe in Umbraco the dropdownlist with "Active SMS Providers" would contain "TwoFactorSMSPerplexProvider" or something like that. Also I tried to set a value like 'TwoFactorSMSPerplexProvider' into the table FortressSettings but that didn't work either.

Can you help me out?

Thanks, Jeffrey

@PeteDuncanson
Copy link
Member

We are encouraging folks to not use SMS as its insecure (well sort of) so we've been using Authenticator by Google.

Will need to get @steroberts89 to write up a little doc on how to create providers as its his black magic that does that bit and its all in his head :)

@cssquirrel
Copy link
Contributor

I've created a new issue, #9, to cover the need for documentation on how to extend functionality. I'm going to close this issue as wontfix, though, as we won't be implementing an SMS provider ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants