From c8c40e74adcd4d7b0dec88a33a7475c8e0b6856c Mon Sep 17 00:00:00 2001
From: OlliL <lehmann@ans-netz.de>
Date: Tue, 31 Dec 2024 00:24:22 +0100
Subject: [PATCH] include ETFs in Trends View

---
 src/model/report/Trends.ts          |  1 +
 src/model/report/TrendsParameter.ts |  1 +
 src/service/ReportService.ts        |  3 ++
 src/views/etf/ListEtfs.vue          |  7 ---
 src/views/reports/ShowTrends.vue    | 81 ++++++++++++++++++++++++++---
 5 files changed, 80 insertions(+), 13 deletions(-)

diff --git a/src/model/report/Trends.ts b/src/model/report/Trends.ts
index 471f194..29b4595 100644
--- a/src/model/report/Trends.ts
+++ b/src/model/report/Trends.ts
@@ -3,4 +3,5 @@ import type { TrendsMonthAmount } from "./TrendsMonthAmount";
 export type Trends = {
   trendsSettled?: Array<TrendsMonthAmount>;
   trendsCalculated?: Array<TrendsMonthAmount>;
+  trendsEtfs?: Array<TrendsMonthAmount>;
 };
diff --git a/src/model/report/TrendsParameter.ts b/src/model/report/TrendsParameter.ts
index 2a7a934..1ef3620 100644
--- a/src/model/report/TrendsParameter.ts
+++ b/src/model/report/TrendsParameter.ts
@@ -2,4 +2,5 @@ export type TrendsParameter = {
   startDate: Date;
   endDate: Date;
   selectedCapitalsourceIds?: Array<number>;
+  selectedEtfIds?: Array<number>;
 };
diff --git a/src/service/ReportService.ts b/src/service/ReportService.ts
index 59cfc41..0ff3cf6 100644
--- a/src/service/ReportService.ts
+++ b/src/service/ReportService.ts
@@ -106,6 +106,7 @@ class ReportService extends AbstractService {
       endDate: new Date(showTrendsFormResponse.maxDate),
       selectedCapitalsourceIds:
         showTrendsFormResponse.settingTrendCapitalsourceIds,
+      selectedEtfIds: showTrendsFormResponse.settingTrendEtfIds,
     };
 
     return trendsTransporter;
@@ -117,6 +118,7 @@ class ReportService extends AbstractService {
     request.startDate = getISOStringDate(trendsParameter.startDate);
     request.endDate = getISOStringDate(trendsParameter.endDate);
     request.capitalSourceIds = trendsParameter.selectedCapitalsourceIds;
+    request.etfIds = trendsParameter.selectedEtfIds;
 
     const response = await this.api.showTrendsGraph(request);
 
@@ -125,6 +127,7 @@ class ReportService extends AbstractService {
     const result: Trends = {
       trendsCalculated: showTrendsGraphResponse.trendsCalculatedTransports,
       trendsSettled: showTrendsGraphResponse.trendsSettledTransports,
+      trendsEtfs: showTrendsGraphResponse.trendsEtfTransports,
     };
 
     return result;
diff --git a/src/views/etf/ListEtfs.vue b/src/views/etf/ListEtfs.vue
index 4f39453..f1605f3 100644
--- a/src/views/etf/ListEtfs.vue
+++ b/src/views/etf/ListEtfs.vue
@@ -122,13 +122,6 @@ const reloadView = () => {
 
   CrudEtfService.fetchAllEtf()
     .then((_etfs) => {
-      _etfs.sort((a, b) => {
-        if (!a.name && !b.name) return 0;
-        else if (!a.name) return -1;
-        else if (!b.name) return 1;
-
-        return a.name.toUpperCase().localeCompare(b.name.toUpperCase());
-      });
       allEtfs.value = _etfs;
       searchContent();
     })
diff --git a/src/views/reports/ShowTrends.vue b/src/views/reports/ShowTrends.vue
index a20f1c6..65a5fec 100644
--- a/src/views/reports/ShowTrends.vue
+++ b/src/views/reports/ShowTrends.vue
@@ -68,6 +68,30 @@
                   </div>
                 </div>
 
+                <div class="row no-gutters flex-lg-nowrap">
+                  <div class="col-12 mb-3 text-start">
+                    <label for="etfs" style="opacity: 0.65"
+                      ><small>{{ $t("General.etfs") }}</small></label
+                    >
+                    <select
+                      v-model="selectedEtfIds"
+                      id="etfIds"
+                      name="etfIds"
+                      class="form-select form-control"
+                      multiple
+                      size="4"
+                    >
+                      <option
+                        v-for="value of etfSelectBoxValues"
+                        :key="value.id"
+                        :value="value.id"
+                      >
+                        {{ value.value }}
+                      </option>
+                    </select>
+                  </div>
+                </div>
+
                 <div class="row no-gutters flex-lg-nowrap">
                   <div class="col-12">
                     <button type="submit" class="btn btn-primary">
@@ -131,6 +155,8 @@ import type { TrendsParameter } from "@/model/report/TrendsParameter";
 
 import ReportService from "@/service/ReportService";
 import { handleBackendError } from "@/tools/views/HandleBackendError";
+import CrudEtfService from "@/service/CrudEtfService";
+import type { Etf } from "@/model/etf/Etf";
 
 const { t } = useI18n();
 
@@ -146,6 +172,7 @@ const schema = {
 
 const dataLoaded = ref(false);
 const trendsGraphLoaded = ref(false);
+const allEtfs = ref(new Array<Etf>());
 const startDate = ref(new Date());
 const endDate = ref(new Date());
 const chartData = ref({
@@ -178,6 +205,21 @@ const chartData = ref({
         gradient.addColorStop(0, "rgba(104, 155, 222, 1)");
         gradient.addColorStop(1, "rgba(174, 174, 250, 1)");
 
+        return gradient;
+      },
+    },
+    {
+      label: t("General.etfs"),
+      data: new Array<number | null>(),
+      fill: true,
+      borderColor: "#be2200",
+      backgroundColor: (ctx: any) => {
+        const canvas = ctx.chart.ctx;
+        const gradient = canvas.createLinearGradient(0, 500, 0, 0);
+
+        gradient.addColorStop(0, "rgba( 253, 112, 81, 1)");
+        gradient.addColorStop(1, "rgba( 242, 47, 6 , 1)");
+
         return gradient;
       },
     },
@@ -219,6 +261,7 @@ const chartOptions = ref({
       },
     },
     y: {
+      stacked: true,
       title: {
         text: t("Reports.title.trendAmount"),
         display: true,
@@ -258,10 +301,17 @@ type ChartData = {
 
 const currency = t("General.currency");
 const capitalsourceStore = useCapitalsourceStore();
-const selectBoxValues = computed((): Array<SelectBoxValue> => {
-  return capitalsourceStore.getAllAsSelectBoxValues();
-});
+const selectBoxValues = computed(
+  (): Array<SelectBoxValue> => capitalsourceStore.getAllAsSelectBoxValues(),
+);
+const etfSelectBoxValues = computed(
+  (): Array<SelectBoxValue> =>
+    allEtfs.value.map((etf) => {
+      return { id: etf.id, value: etf.name } as SelectBoxValue;
+    }),
+);
 
+const selectedEtfIds = ref(new Array<number>());
 const { handleSubmit, values, setFieldTouched } = useForm();
 const {
   value: capitalsourceIds,
@@ -297,8 +347,8 @@ const loadData = () => {
   serverErrors.value = new Array<string>();
 
   dataLoaded.value = false;
-  ReportService.showTrendsForm()
-    .then((trendsTransporter) => {
+  Promise.all([ReportService.showTrendsForm(), CrudEtfService.fetchAllEtf()])
+    .then(([trendsTransporter, etfTransporters]) => {
       const minDate = trendsTransporter.startDate;
       const maxDate = trendsTransporter.endDate;
 
@@ -308,6 +358,11 @@ const loadData = () => {
       if (trendsTransporter.selectedCapitalsourceIds)
         capitalsourceIds.value = trendsTransporter.selectedCapitalsourceIds;
 
+      if (trendsTransporter.selectedEtfIds)
+        selectedEtfIds.value = trendsTransporter.selectedEtfIds;
+
+      allEtfs.value = etfTransporters;
+
       dataLoaded.value = true;
       Object.keys(values).forEach((field) => setFieldTouched(field, false));
     })
@@ -327,6 +382,7 @@ const showTrends = handleSubmit(() => {
     startDate: startDate.value,
     endDate: _endDate,
     selectedCapitalsourceIds: capitalsourceIds.value,
+    selectedEtfIds: selectedEtfIds.value,
   };
   ReportService.showTrendsGraph(trendsParameter)
     .then((trends) => {
@@ -357,7 +413,7 @@ const showTrends = handleSubmit(() => {
 
           for (let i = 0; i < dataSettled.length; i++) {
             if (i + 1 == dataSettled.length) {
-              dataCalculated.push(dataSettled[i]);
+              dataCalculated.push(0.0);
             } else {
               dataCalculated.push(null);
             }
@@ -377,6 +433,19 @@ const showTrends = handleSubmit(() => {
           chartData.value.datasets[1].hidden = true;
         }
 
+        const dataEtf: Array<number> | undefined = trends.trendsEtfs?.map(
+          function (e) {
+            return e.amount;
+          },
+        );
+
+        if (dataEtf) {
+          chartData.value.datasets[2].data = dataEtf;
+          chartData.value.datasets[2].hidden = false;
+        } else {
+          chartData.value.datasets[2].hidden = true;
+        }
+
         const startLabel = chartData.value.labels[0];
         const endLabel =
           chartData.value.labels[chartData.value.labels.length - 1];