Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout "none" implementation inconsistent with its description #33

Closed
Omikhleia opened this issue Apr 15, 2023 · 0 comments · Fixed by #38
Closed

Layout "none" implementation inconsistent with its description #33

Omikhleia opened this issue Apr 15, 2023 · 0 comments · Fixed by #38
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation question Further information is requested
Milestone

Comments

@Omikhleia
Copy link
Owner

The doc says:

In passing, the none layout uses margins of 1 inch on all sides. It just exists because it’s the base component for other layouts.

Er... 1 inch? Nope...

function layout:_init (_)
  self.inner = "width(page)/6"
  self.outer = "width(page)/6"
  self.head = "height(page)/6"
  self.foot = "height(page)/6"
  self.offset = "0"
end

That's visible:
image

This said, no idea what's best here, what the doc states or what the code does. And I can't remember (nor find in the history) how I arrived to that discrepancy (... 1/6th has advantages too)

@Omikhleia Omikhleia added bug Something isn't working documentation Improvements or additions to documentation question Further information is requested labels Apr 15, 2023
@Omikhleia Omikhleia added this to the 2.0.1 milestone Apr 15, 2023
@Omikhleia Omikhleia self-assigned this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant