Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package resilient.bible.tei issues (style leaking, headers/folios disappearing) #86

Closed
Omikhleia opened this issue Sep 20, 2024 · 0 comments · Fixed by #87
Closed

Package resilient.bible.tei issues (style leaking, headers/folios disappearing) #86

Omikhleia opened this issue Sep 20, 2024 · 0 comments · Fixed by #87
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Omikhleia
Copy link
Owner

Probably present from some time, but I only returned to the "Gothic project" recently, after a hiatus...

  • Some settings can leak outside their scope when collating sides notes, due to a missing popState() in an early return (e.g. italic, centering etc. can then propagate to the document)
  • Bad interaction with book matters (and cover pages etc.) when enabled in a wrapping master document: the book matter logic cancels the headers and folios. We have to re-enable them at some point (in the TEI book tag, or in the resilient master, or both?)

The fixes are mere one-liners, though finding the root cause wasn't that immediate.

@Omikhleia Omikhleia self-assigned this Sep 20, 2024
@Omikhleia Omikhleia added the bug Something isn't working label Sep 20, 2024
@Omikhleia Omikhleia added this to the 2.5.0 milestone Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant