Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange SampleRateContainer with SamplePeriod class #234

Open
Apollo3zehn opened this issue Apr 1, 2020 · 0 comments
Open

Exchange SampleRateContainer with SamplePeriod class #234

Apollo3zehn opened this issue Apr 1, 2020 · 0 comments

Comments

@Apollo3zehn
Copy link
Member

  • based on TimeSpan:
public SamplePeriod(TimeSpan period)
{
    _period = period;
    this.EnsureIsMultipleOf(period, TimeSpan.FromSeconds(1));
}
  • Should be multiple of 1 second because data writer base assumes this condition
  • Should also be multiple of 1 day (e.g. sample period of 18 seconds is multiple of 1 day but others are not) for aggregations
  • Timespan limits frequency to 10 MHz, but one could simply multiply all values by 1000 to get higher frequencies (on the cost of constraints for lower frequency limit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant