Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: After latest fix I got another crash reports on Crashlytics 😔 #1526

Closed
1 task done
iballan opened this issue Dec 6, 2024 · 5 comments · Fixed by #1528
Closed
1 task done

[Bug]: After latest fix I got another crash reports on Crashlytics 😔 #1526

iballan opened this issue Dec 6, 2024 · 5 comments · Fixed by #1528

Comments

@iballan
Copy link

iballan commented Dec 6, 2024

What happened?

Got a crash reports on Crashlytics for a feature that I dont even use in the app! InAppMessages

Fatal Exception: NSInvalidArgumentException
-[NSError objectForKeyedSubscript:]: unrecognized selector sent to instance 0x302bc2190

Steps to reproduce?

Most probably users are using the app offline.

What did you expect to happen?

To not crash

OneSignal iOS SDK version

Release 5.2.8

iOS version

17

Specific iOS version

* iOS 17 46%
* iOS 18 36%
* iOS 16 18%

Relevant log output

Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x83f20 __exceptionPreprocess
1  libobjc.A.dylib                0x16018 objc_exception_throw
2  CoreFoundation                 0x18d480 +[NSObject(NSObject) _copyDescription]
3  CoreFoundation                 0x20fb4 ___forwarding___
4  CoreFoundation                 0x208d0 _CF_forwarding_prep_0
5  OneSignalInAppMessages         0xba80 __77-[OSMessagingController attemptFetchWithRetries:rywData:attempts:retryLimit:]_block_invoke.90 + 320 (OSMessagingController.m:320)
6  OneSignalCore                  0x9e50 -[OneSignalClient handleJSONNSURLResponse:data:error:isAsync:withRequest:onSuccess:onFailure:] + 214 (OneSignalClient.m:214)
7  OneSignalCore                  0x9338 __54-[OneSignalClient executeRequest:onSuccess:onFailure:]_block_invoke + 110 (OneSignalClient.m:110)
8  myApp                        0x4e7a98 __InstrumentDataTaskWithRequestCompletionHandler_block_invoke_2 + 306 (FPRNSURLSessionInstrument.m:306)
9  myApp                        0x4e7a98 __InstrumentDataTaskWithRequestCompletionHandler_block_invoke_2 + 306 (FPRNSURLSessionInstrument.m:306)
10 CFNetwork                      0x6ac84 CFHTTPCookieCreateWithResponseHeaderFields
11 CFNetwork                      0x6aa58 CFHTTPCookieCreateWithResponseHeaderFields
12 libdispatch.dylib              0x213c _dispatch_call_block_and_release
13 libdispatch.dylib              0x3dd4 _dispatch_client_callout
14 libdispatch.dylib              0xb400 _dispatch_lane_serial_drain
15 libdispatch.dylib              0xbf64 _dispatch_lane_invoke
16 libdispatch.dylib              0x16cb4 _dispatch_root_queue_drain_deferred_wlh
17 libdispatch.dylib              0x16528 _dispatch_workloop_worker_thread
18 libsystem_pthread.dylib        0x4934 _pthread_wqthread
19 libsystem_pthread.dylib        0x10cc start_wqthread

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mikemonaco
Copy link

How frequently are you seeing this crash (compared to the 5.2.7 crash)? I am considering upgrading to 5.2.8 to fix the other issue, but if this issue is worse I might hold off.

@mikemonaco
Copy link

@nan-li is there a 5.2.9 coming soon to fix this?

@iballan
Copy link
Author

iballan commented Dec 10, 2024

@mikemonaco it appears way less frequently than the other error in crashlytics

@nan-li
Copy link
Contributor

nan-li commented Dec 11, 2024

Hi everyone thank you for reporting, it looks like a bug that we are fixing.

@nan-li
Copy link
Contributor

nan-li commented Dec 17, 2024

Hi everyone this is released in Release 5.2.9. Thank you for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants