Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneSignal load time #307

Closed
kamendo opened this issue Nov 29, 2017 · 7 comments
Closed

OneSignal load time #307

kamendo opened this issue Nov 29, 2017 · 7 comments

Comments

@kamendo
Copy link

kamendo commented Nov 29, 2017

screen shot 2017-11-29 at 18 54 25

Can I do something about this (delay initialization may be?) Its slowing my app startup time :)

@Formerly
Copy link

I also have the same problem, trouble handling as soon as possible. Thank you.

@bank18651
Copy link

I also got this too.

@Nightsd01
Copy link
Contributor

Most of this load time is due to our SDK’s interaction with the Objective-C runtime which can be a bit slow. We do a lot of swizzling so that developers don’t have to add a lot of boilerplate code to their apps.

I will look into how we can make this more efficient and perhaps delay it so that it doesn’t block initialization of the app itself.

@chrismanderson
Copy link

One potential solution is to let devs use the SDK without swizzling. I've asked this on the intercom in the past and seen other discussions around it but always seem to get back "swizzling is fine" 😁. I use Segment for my OneSignal integration precisely because this SDK swizzles.

If swizzling does cause startup time issues, seems like a prime opportunity to build in the functionality to allow it to work without it.

@revolter
Copy link
Contributor

Being able to manually initialize the SDK so it doesn't rely on swizzling would be great!

@rgomezp
Copy link
Contributor

rgomezp commented Apr 3, 2019

Closing issue. Note: request still under consideration

@rgomezp rgomezp closed this as completed Apr 3, 2019
@alexandre-g
Copy link

Hi, any updates on this? Getting OneSignal : 500.26 milliseconds init time on last gen iPad Air.
Apple's recommended is 400ms for the whole app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants