Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice & Help Request Regarding RN 0.29 Support #57

Closed
avishayil opened this issue Jul 1, 2016 · 8 comments
Closed

Notice & Help Request Regarding RN 0.29 Support #57

avishayil opened this issue Jul 1, 2016 · 8 comments

Comments

@avishayil
Copy link
Contributor

In RN 0.29 fb changed the way RN libraries should be included in Android, and listen to application life cycle. I'm working right now on a solution for the migration, but I'd be happy to get some help from Android experts around here.

Version 1.1.9 would include all features and will support RN version < 0.29, while version 1.2.0 and up will support RN 0.29 and up. New features will be supported only on RN 0.29 and up once we'll figure a solution to migrate the library according to the new changes.

@jkasten2
Copy link
Member

jkasten2 commented Jul 1, 2016

@avishayil Can you link their doc?

The OneSignal native code is designed to handle either an Activity or Application Context already.

@avishayil
Copy link
Contributor Author

@jkasten2
Copy link
Member

jkasten2 commented Jul 1, 2016

@avishayil
You can use getApplicationContext() instead.

@avishayil
Copy link
Contributor Author

Yeah, I'm trying that but I have problem using the notificationOpenedHandler, can't get it to work using the new life cycle.

@avishayil
Copy link
Contributor Author

Migration process:
https://github.com/geektimecoil/react-native-onesignal/tree/RN-0.29

Couldn't seem to listen to Application lifecycle properly...

@avishayil
Copy link
Contributor Author

Nailed it.

@satya164
Copy link

satya164 commented Jul 3, 2016

Note that listening to lifecycle events and getCurrentActivity has been supported in RN for quite a few versions. So it's not a breaking change for you.

@avishayil
Copy link
Contributor Author

Thanks @satya164 !, i'll definitely take a look on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants