Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences in procs containing strings that look like SQL comments not found #279

Open
aredridel opened this issue Jan 21, 2014 · 2 comments

Comments

@aredridel
Copy link
Contributor

Given a proc with this in the body:
SET @q = CONCAT('CALL ', routine, '-- ', BADFUNCTION());

and its replacement

SET @q = CONCAT('CALL ', routine, '-- ', UUID_SHORT());

The change is not detected.

@aredridel
Copy link
Contributor Author

(Don't ask why I'm doing this. It was a horrible idea anyway. But I broke the comparison doing it.)

@iarna
Copy link
Contributor

iarna commented Jan 21, 2014

Ahh, yeah, for the purposes of comparison it does a VERY naive comment removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants