-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options object in <ons-back-button> #1040
Comments
👍 |
Which way do you think it's better? I just implemented getter/setter in |
Could you write proposal spec shortly? When andreas and I agree its proposal, it's OK to implement. |
@anatoo @argelius We need to pass the options object to
Attributes have priority over object modifications. |
👍 |
I think this looks good! |
@argelius @anatoo We can have an options object for
navigator.popPage({...})
with things likerefresh
oronTransitionEnd
, but currentlyons-back-button
is set to donavigator.popPage({cancelIfRunning: true});
and nothing else. I guess we should add a way to assign an options object toons-back-button
. How do you think it should be done?pushPage
: `navigator.pushPage( 'newpage.html', { ... , backButtonOptions: { ... } }<ons-back-button options="objectVariableName">
or<ons-back-button refresh="true" onTransitionEnd="functionName">
. The last example can be a bit hard to pass functions with arguments.navigator.getCurrentPage().setBackButtonOptions( { ... } );
What do you think?
The text was updated successfully, but these errors were encountered: