Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog container should have minimum height #1162

Closed
argelius opened this issue Jan 8, 2016 · 1 comment
Closed

Dialog container should have minimum height #1162

argelius opened this issue Jan 8, 2016 · 1 comment
Milestone
2.0

Comments

@argelius
Copy link
Contributor

argelius commented Jan 8, 2016

The dialog-container elemnt should have same min-height as the parent element so it covers the whole dialog.

I don't know which one of min-height or height: 100%; is best. Please chose the one you like. :)
@argelius argelius added the bug label Jan 8, 2016
@argelius argelius added this to the 2.0 milestone Jan 8, 2016
@frandiox
Copy link
Contributor

@argelius dialog-container already has height: inherit. Isn't that enough?

@lock lock bot added the outdated label May 18, 2018
@lock lock bot unassigned frandiox May 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@frandiox @argelius