-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabbar broken in React #1528
Comments
@argelius What about setting a page loader that do nothing?
|
@anatoo Good idea! I will try this |
Actually this is still causing an error:
|
hmm... Do you set "page" attribute on ons-tab? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@anatoo I think #1492 broke the tabbar in React.
It's trying to use the
pageLoader
but that is not necessary in React since the pages are already rendered by React. Do you have any idea what changed? I tried to debug the code but there are a lot of changes in both<ons-tabbar>
and<ons-tab>
and I couldn't find what change is causing the problem.In React the pages are rendered and put into the
.tab-bar__content
element so there is no need to load pages.The text was updated successfully, but these errors were encountered: