Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ons-toolbar displays on top of ons-modal #182

Closed
nokturnal opened this issue Aug 7, 2014 · 1 comment
Closed

ons-toolbar displays on top of ons-modal #182

nokturnal opened this issue Aug 7, 2014 · 1 comment

Comments

@nokturnal
Copy link

In 1.1.1, the following causes the ons-toolbar to appear on top of the ons-modal:

<ons-page ng-controller="someController">
    <ons-modal var="myModal">
        <p>this is my modal: {{someScopeVar}}</p>
    </ons-modal>

    <ons-toolbar>
        <div class="left">
            <ons-back-button>Back</ons-back-button>
        </div>
        <div class="center">Some Toolbar Title</div>
    </ons-toolbar>

    <ons-row>
        <ons-col align="center">
            <div class="content-padded">
                some content
            </div>
        </ons-col>
    </ons-row>
</ons-page>

When ons-modal is rendered, it is placed inside a div.page__content which is absolutely positioned with 44px top padding hence giving the ellusion ons-toolbar is on top of the ons-modal, kind of defeating the purpose of a modal dialog :)

Cheers

@nokturnal nokturnal changed the title ons-toolbar displays on top of ons-modal: ons-toolbar displays on top of ons-modal Aug 7, 2014
@anatoo
Copy link
Contributor

anatoo commented Aug 8, 2014

Hi @nokturnal,

Thank you for this reporting.
"ons-modal" should display itself on top of current "ons-page" and "ons-toolbar".
We will fix this problem.

@anatoo anatoo added the bug label Aug 8, 2014
@anatoo anatoo closed this as completed in 8b2662a Aug 19, 2014
@lock lock bot added the outdated label May 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants