feat: upgrade to solc 0.6.10 and added GsnCapableDocumentStore #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justussoh
commented
Nov 18, 2020
| @@ -2,6 +2,9 @@ | |||
| "extends": ["solhint:recommended"], | |||
| "plugins": ["prettier"], | |||
| "rules": { | |||
| "indent": ["error", 2] | |||
There was a problem hiding this comment.
| import "@opengsn/gsn/contracts/BaseRelayRecipient.sol"; | ||
| import "@opengsn/gsn/contracts/interfaces/IKnowForwarderAddress.sol"; | ||
|
|
||
| contract GsnCapableDocumentStore is BaseRelayRecipient, IKnowForwarderAddress, GsnCapable { |
There was a problem hiding this comment.
why not extend the base document store too?
test/GsnCapableDocumentStore.js
Outdated
|
|
||
| const issue = documentMerkleRoot => instance.issue(documentMerkleRoot); | ||
|
|
||
| describe("constructor", () => { |
There was a problem hiding this comment.
if inheriting from document store base contract can remove these test?
Nebulis
reviewed
Nov 23, 2020
* fix: bytecode * fix: refactored data * fix: lint Co-authored-by: Raymond Yeh <[email protected]>
yehjxraymond
approved these changes
Nov 27, 2020
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Removed:
Todo: