Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to ignore user specified changes #129

Open
elibracha opened this issue Feb 3, 2020 · 2 comments
Open

Adding option to ignore user specified changes #129

elibracha opened this issue Feb 3, 2020 · 2 comments

Comments

@elibracha
Copy link

Hi,

I think that an option to let user ignore some changes would be nice, like letting the user define a yaml file with all the ignore changes he would like. and not fail if the changes are ignored. I am willing to help with this and create the necessary modules.

Would you be interested in this ?

@elibracha elibracha changed the title adding option to ignore user specified changes Adding option to ignore user specified changes Feb 3, 2020
@nhoughto
Copy link

I think this is similar to what I was thinking.

My use-case is to diff prod spec vs development spec and assert no breaking changes and fail the build if breaking changes, but in the case that we expect a breaking change it would be nice to be able to flag it so the build doesn't break.

@nhoughto
Copy link

Near as I can tell this would be a change to the CLI code / the thing that uses the ChangedOpenApi result object, the actual comparison itself you wouldn't want to change just how you interpret it. For example you likely still want to show that there is a change, just flag it with * ignored or similar. Which you should be able to derived from the Changed result obj and the objects it holds (hopefully can access openapi spec annotations via it).

so Main in CLI and likely the renderers to show the ignore flags. Is there appetite for this to be PR'd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants