Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ][JAVA] Add @Nullable/@Nonnull annotations to POJO attributes and setters #19600

Closed
nvervelle opened this issue Sep 17, 2024 · 3 comments · Fixed by #19617
Closed

[REQ][JAVA] Add @Nullable/@Nonnull annotations to POJO attributes and setters #19600

nvervelle opened this issue Sep 17, 2024 · 3 comments · Fixed by #19617

Comments

@nvervelle
Copy link
Contributor

I'm using java generator for webclient, and the generated POJO classes only contain @Nullable/@Nonnull annotations for the getters, but not for the attributes themselves or the setters.

When using tools like NullAway, it causes some issues because you cannot easily use the fluent setters when setting a nullable attribute, because the setter is not annotated with @Nullable.

I'd like to add the annotations to the attributes and the setters, so that it's easier to enable tools like NullAway on code using the generated clients.

I will submit a PR for this feature request.

@nvervelle
Copy link
Contributor Author

PR submitted : #19617

@c99SRS
Copy link

c99SRS commented Oct 1, 2024

Hi @nvervelle pls assign this to me. Want to work on this

@nvervelle
Copy link
Contributor Author

@c99SRS : the PR is submitted, what is the work you were thinking of ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants