Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI is no more, migrate to GitHub Actions #172

Closed
pavel-kirienko opened this issue Jul 20, 2021 · 3 comments · Fixed by #174
Closed

Travis CI is no more, migrate to GitHub Actions #172

pavel-kirienko opened this issue Jul 20, 2021 · 3 comments · Fixed by #174
Assignees

Comments

@pavel-kirienko
Copy link
Member

https://github.com/UAVCAN/libcanard/blob/master/.travis.yml

@coderkalyan coderkalyan self-assigned this Jul 20, 2021
@coderkalyan coderkalyan linked a pull request Sep 11, 2021 that will close this issue
@pavel-kirienko
Copy link
Member Author

pavel-kirienko commented Sep 14, 2021

Reopening because there are still configuration issues with CI.

  • Test coverage measurement is not working, the reported coverage is 0%. This is probably because the sonar scanner configuration is incomplete -- it used to include more options:

https://github.com/UAVCAN/libcanard/blob/2a116170285fb47fcaae150ad21c2ccde0756a5f/.travis.yml#L33-L39

  • SonarQube is analyzing irrelevant files, specifically catch.hpp (the unit testing framework), test files, and CMake-generated C++ files (because the sonar.sources parameter is configured incorrectly):
    image

Please avoid merging things without review, as it would help us avoid issues like this.

@coderkalyan
Copy link
Contributor

Please avoid merging things without review, as it would help us avoid issues like this.

Sorry, my intent was not to merge without review, but I found that the sonarcloud was not actually running anything on the PR branch since no code had changed. Now that I know it runs correctly, I will fix these issues and submit for review.

@pavel-kirienko
Copy link
Member Author

Both of these deficiencies have been addressed by #181, thanks! One new issue is that Travis-CI integration is still enabled for some reason, as I wrote in a comment there, so I am going to keep this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants