Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+++ Compression Bug in F2.js download #17

Closed
timburcham opened this issue Dec 27, 2012 · 1 comment
Closed

+++ Compression Bug in F2.js download #17

timburcham opened this issue Dec 27, 2012 · 1 comment
Assignees
Labels

Comments

@timburcham
Copy link
Contributor

Inside the F2.js default download, EasyXDM is included. Inside the EasyXDM line (line 60), 2 references of '+ ++' are included. When run through some compression engines, this is compressed to '+++', which breaks some browsers like Firefox.

The fix is to convert the line just slightly to protect the second and third plus:

  • ++i

to

  • (++i)
@brianbaker
Copy link
Member

Offending line in EasyXDM is line 2402: _callbacks["" + (++_callbackCounter)] = callback;

@ghost ghost assigned brianbaker Jan 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants