Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nexmo: update to 3.x #329

Closed
josephjclark opened this issue Aug 2, 2023 · 2 comments · Fixed by #338
Closed

nexmo: update to 3.x #329

josephjclark opened this issue Aug 2, 2023 · 2 comments · Fixed by #338
Assignees
Labels

Comments

@josephjclark
Copy link
Collaborator

josephjclark commented Aug 2, 2023

Version 2.x of the nexmo adaptor uses jsonwebtoken 7.4.3, which has as security vulnerability.

We should update to the 3.x version. This is a major version bump so we need to check that signatures are all compatible.

Recommend we make this a minor version bump to the adaptor.

This closes:

@mtuchi mtuchi self-assigned this Aug 3, 2023
@mtuchi mtuchi linked a pull request Aug 3, 2023 that will close this issue
4 tasks
@mtuchi mtuchi mentioned this issue Aug 3, 2023
4 tasks
@mtuchi
Copy link
Collaborator

mtuchi commented Aug 3, 2023

Nexmo is now called Vonage, and the nodejs package for nexmo is no longer maintained, See mantainance notice here . The new package that needs to replace nexmo is @vonage/server-sdk See vonage-node-sdk here.

I have started to update the adaptor to use vonage-node-sdk but two pending task remain

  1. Testing using a vonage sandbox
  2. A discussion on the adaptor name, Do we rename nexmo to vonage or keep the name and update our readme ?

@josephjclark
Copy link
Collaborator Author

@mtuchi Looking at this again I can't see where I got nexmo 3.x from 🤔 nexmo npm seems to stop at 2.9.1

We should be able to just update to 2.9.1 (the vulnerability is fixed in 2.6.0, see Vonage/vonage-node-sdk#179).

Don't worry about the other stuff - we'll deal with that when someone asks for a Vonage adaptor 😎

@mtuchi mtuchi mentioned this issue Aug 3, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants