Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use ast.json to drive typings #33

Closed
josephjclark opened this issue Feb 6, 2025 · 1 comment
Closed

Don't use ast.json to drive typings #33

josephjclark opened this issue Feb 6, 2025 · 1 comment

Comments

@josephjclark
Copy link
Collaborator

The current implementation uses ast.json to drive language services.

What's nice about ast.json is that every adaptor has one. Unfortunately it's quite a limited structure. It doesn't handle namespaces at all, and makes a bunch of assumptions about how adaptors are shaped.

I generally want to use @openfn/describe-package to drive language analysis. Sadly describe-package, over in kit, also has a few problems.

@doc-han
Copy link
Collaborator

doc-han commented Feb 18, 2025

Resolved by #27

@doc-han doc-han closed this as completed Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants