-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voting feature of anonymous user #73
base: master
Are you sure you want to change the base?
Conversation
Nice work 👍 You need to resolve the Travis error In terms of UI, you must remove the submit button and an entry must be made as soon as the user interacts with it. The average rating (in a format like [4.9 ⭐] ) should appear beside the algorithm name. You must, also, make a default entry of 5 rating for each algorithm, to begin with. 👍 Kindly make appropriate changes and let us know when it is ready for review. 👍 |
OKK Sir
Shweta Kumari
3rd-year B.Tech. IT
IIIT Vadodara
…On Fri, Mar 2, 2018 at 1:49 AM, Aditya Chatterjee ***@***.***> wrote:
Nice work 👍
You need to resolve the Travis error django.db.utils.OperationalError: no
such table: search_votes. You need to register the Votes model in
setting.py.
In terms of UI, you must remove the submit button and an entry must be
made as soon as the user interacts with it. The average rating (in a format
like [4.9 ⭐️] ) should appear beside the algorithm name. You must, also,
make a default entry of 5 rating for each algorithm, to begin with. 👍
Kindly make appropriate changes and let us know when it is ready for
review. 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWPbVyHB1BXgC1ccXDSTsx6zpVimLlF5ks5taFflgaJpZM4SWO6h>
.
|
89521ed
to
6d93cf5
Compare
@AdiChat The build is failing because there are no commands regarding |
I think you can remove the table from your local DB, maybe it will regenerate the error on your PC, then you can fix it. |
@iattempt I have already tried it. The main problem is as |
Did you try to adding command |
@AdiChat Please review. |
As we are expanding to other sources of search results, providing feedback option to only Cosmos results may be odd. You may convert this to a general feedback form located at the lower right corner as a popup. In addition to voting, you may add an option to add a comment and also, store the current url/ search term. The general structure should remain the same. We can use this data to provide additional insights to users like trending search terms, better recommendations and others. Kindly take a look into this. 👍 |
@AdiChat please review |
@AdiChat Please Review |
@AdiChat Please Review |
You must clean this pull request regarding |
@AdiChat please Review |
Nice work 👍 It is intended to be a general voting section instead of being tied to a particular result. This requires a redesign of the UI to the lower right corner as a popup. In the current design, voting reloads the page but ideally, it should cover everything in the background. For comments/ discussions, we must use our Discourse forum. Instead of asking users to rate, we can ask a specific question like "What do you like about this page?" with options like "Code results, Video results, Everything". You can, also, take a look at third-party integrations that can provide such a solution. Kindly take a look into this. 👍 |
Checklist
develop
branch.Which issue does this PR fix?:
fixes: #60
Why do we need this PR?:
This would let the user rate the search result on scale of 1 to 5. It store the
votes
indatabase
along withIP address
andalgorithm name
.If relevant, please include a screenshot.