Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings are being saved even when they haven't been modified #55

Closed
steveatinfincia opened this issue Jan 6, 2020 · 2 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@steveatinfincia
Copy link
Contributor

For some reason, ground pi settings are being marked as though they've been modified even when they haven't causing the settings system in the app to save them.

This isn't inherently a problem as long as the settings system is working properly, but it's not necessary either.

@steveatinfincia steveatinfincia added the bug Something isn't working label Jan 6, 2020
@steveatinfincia steveatinfincia self-assigned this Jan 6, 2020
@htcohio
Copy link

htcohio commented Jan 6, 2020

Hey,

So you're saying that the ground pi is periodically saving settings or, being triggered to save settings even when they haven't been modified?

That would explain why there are instances where Air & ground lose synchronization with settings even without changing anything.

this has not happened in recent test but in the past it has.

@steveatinfincia
Copy link
Contributor Author

I mean when you open the settings panel and change something like hotspot txpower, and then hit save, the app sends a bunch of other settings to the ground station to be saved as well even though the user hasn't changed them.

Because the other settings aren't actually changed it can't cause a problem with anything else (it's just telling the ground station to write the same value into the settings file that's already there).

@steveatinfincia steveatinfincia added this to the v0.4 milestone Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants