Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylesheets hard-code organization names #902

Open
1ec5 opened this issue Oct 29, 2024 · 2 comments
Open

Stylesheets hard-code organization names #902

1ec5 opened this issue Oct 29, 2024 · 2 comments

Comments

@1ec5
Copy link
Member

1ec5 commented Oct 29, 2024

In the Historical stylesheet, the points_acra and points_oxfam symbol layers filter the buildings layer by many variants of the names “Acra” and ”Oxfam” in order to assign what appear to be two organization logos:

https://github.com/OpenHistoricalMap/map-styles/blob/0a3584f80897c31dfb075b18c3da121138df881b/main/main.json#L6058-L6114

Is this intentional? If so, we should make the matching less fragile by exposing operator:wikidata=* and brand:wikidata=* in the tiles and having these layers match on those fields instead. In OpenStreetMap, the name suggestion index ensures that Oxfam-operated facilities are tagged brand:wikidata=Q267941 or operator:wikidata=Q267941, depending on the POI type; I’d expect similar tagging in OHM. I don’t know what “Acra” refers to. Google Images comes up empty for this icon:

https://github.com/OpenHistoricalMap/map-styles/blob/0a3584f80897c31dfb075b18c3da121138df881b/main/poi/acra-18.svg

@vknoppkewetzel
Copy link
Collaborator

hmm I suspect ACRA is similar to OXFAM and referencing something humanitarian aid related, but not positive... their logo isn't a tree (maybe it was once?)
Associazione di Cooperazione Rurale in Africa e America Latina
https://www.acra.it/
https://www.ewabelt.eu/acra-foundation
also: https://www.acra-ssd.org/

hmm although. this maybe confirms my suspician here, in terms of associating it with humanitarian aid (Nathanial also said ??? lol): tilezen/vector-datasource#1424

hot-osm.json referenced here also has ACRA and OXFAM next to each other --> https://github.com/openlayers/ol-mapbox-style/blob/main/test/fixtures/hot-osm/hot-osm.json


With all this said, I think we don't need this in main?

@vknoppkewetzel vknoppkewetzel moved this from TODO Soon to In map-styles repo in OHM Carto Dec 31, 2024
@vknoppkewetzel
Copy link
Collaborator

removed oxfam and acra from styles (main and rail, woodblock and jp do not have) OpenHistoricalMap/map-styles@28d92cf

Will be in next update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In map-styles repo
Development

No branches or pull requests

2 participants