Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use oic.oic.Provider.endp instead of dynamic provider.endpoints in examples #370

Closed
schlenk opened this issue Jun 6, 2017 · 1 comment
Closed
Labels
Milestone

Comments

@schlenk
Copy link
Collaborator

schlenk commented Jun 6, 2017

The examples all create a list of endpoints, then call provider.endpoints = endpoints. For example in op3

But oic.oid.provider.Provider does not have any attribute of that name, only a method called endpoints() that gets overriden. The variable used in the class is called oic.oic.Provider.endp.

So probably the endpoints should be added to that variable instead of overwriting the method with a list.

@decentral1se
Copy link
Contributor

But oic.oid.provider.Provider does not have any attribute of that name, only a method called endpoints() that gets overriden.

That sounds bad!

So probably the endpoints should be added to that variable instead of overwriting the method with a list.

I'll edit the title to reflect that, sounds like a good idea.

@decentral1se decentral1se changed the title Examples endpoint setup is strange Use oic.oic.Provider.endp instead of dynamic provider.endpoints in examples Jun 6, 2017
@decentral1se decentral1se added this to the P2: SHOULD milestone Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants