Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alabaster should not be in runtime deps #598

Closed
artofhuman opened this issue Jan 28, 2019 · 2 comments
Closed

alabaster should not be in runtime deps #598

artofhuman opened this issue Jan 28, 2019 · 2 comments
Assignees
@tpazderka
Labels
enhancement
Milestone
1.0

Comments

@artofhuman
Copy link
Contributor

Hi, ✋

As I can see the alabaster dependency used only for documentation in https://github.com/OpenIDC/pyoidc/blob/master/doc/conf.py#L1.
I think this dependency needed only for developers, not in install deps https://github.com/OpenIDC/pyoidc/blob/master/setup.py#L88
@tpazderka tpazderka added this to the 1.0 milestone Jan 28, 2019
@tpazderka tpazderka self-assigned this Jan 28, 2019
@tpazderka
Copy link
Collaborator

Thanks for the report. The dependency should be moved to docs extras.

@artofhuman artofhuman mentioned this issue Jan 30, 2019
Closed
2 tasks
@tpazderka
Copy link
Collaborator

Merged.

NexediGitlab pushed a commit to SlapOS/slapos that referenced this issue Nov 30, 2021
@EcrinDe
erp5: Add oic library for OpenIdConnect
eafdf51 
* Note from @jerome: We have a useless dependency to
 https://pypi.org/project/alabaster/, a sphynx theme,
 but with oic v0.15.1 it's listed as a dependency
 ( https://github.com/OpenIDC/pyoidc/blob/v0.15.1/setup.py#L89 )
 so we don't have the choice. It was fixed later
 ( CZ-NIC/pyoidc#598 )
 but after python2 support was dropped.
NexediGitlab pushed a commit to SlapOS/slapos that referenced this issue Nov 30, 2021
@EcrinDe
erp5: Add oic library for OpenIdConnect
77bf66b 
* Note from @jerome: We have a useless dependency to
 https://pypi.org/project/alabaster/, a sphynx theme,
 but with oic v0.15.1 it's listed as a dependency
 ( https://github.com/OpenIDC/pyoidc/blob/v0.15.1/setup.py#L89 )
 so we don't have a choice. It was fixed later
 ( CZ-NIC/pyoidc#598 )
 but after python2 support was dropped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpazderka tpazderka

Labels
enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@artofhuman @tpazderka