Refactor SessionDB constructor and use secure defaults #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlenk
changed the title
|
I support this. LGTM. |
4 tasks
|
Would be nice if it is in 0.11. It is a step in the right direction, even if it doesn't go all the way yet. |
|
I'll give it a review and try to merge now. |
added 5 commits
August 7, 2017 10:37
The seed parameter is unused. The password and secrets are directly passed to the DefaultToken Factory and unused otherwise (and badly named as that is not a password)
Moved a lot of SessionDB Init into the conftest.py fixtures.
Change all examples to the shorter SessionDB API.
decentral1se
force-pushed
the
secure_defaults
branch
from
69d01bd to
afcfef4
Compare
added 2 commits
August 7, 2017 10:44
decentral1se
force-pushed
the
secure_defaults
branch
from
afcfef4 to
9cf4dc4
Compare
|
🍻 🍻 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the SessionDB constructor to be less overloaded.
Looking into #326 i found the password and secret parameters are only used when a DefaultToken factory is used, so they do not really belong into the SessionDB class, if we externalize the factories. The seed parameter is not used at all.
So i threw out the parameters from the init and wrote a wrapper that is nearly as convenient as the old API for the test/example cases.
This partially fixes #326 as the defaults are gone, but DefaultToken does not raise nice exceptions yet.
This is still work-in-progress, just wanted to get some extra looks and agreement about the direction this goes.
It would still be nice to refactor a bit more (e.g. the RefreshDB/RefreshTokenFactory divide seems unnecessary) and to get to a point where #146 can be fixed, so one can do a persistent SessionDB without too much troubles.