Peer Review (dev-mode) - Mac

[NimG98]

• Dockerfiles should have FROM openliberty/open-liberty:kernel-java8-openj9-ubi
• need comments for inventory and system pom.xml
  • surefire: <!-- Plugin to run unit tests -->
  • LMP: <!-- Enable liberty-maven plugin -->
  • failsafe: <!-- Plugin to run functional tests -->
  • add <!-- Provided dependencies --> above microprofile dependency
  • in properties section for plugin versions, comment should be <!-- Plugin versions -->
  • in properties section <!-- Open Liberty runtime --> should be
    <!-- Liberty configuration -->
• diff in spacing between
  • finish and start system/src/main/liberty/config/server.xml
  • finish and start inventory/src/main/java/io/openliberty/guides/inventory/client/SystemClient.java

Enabling MicroProfile Fault Tolerance

• Use the old sentence talking about the dependency in the pom.
  • do it like how the other microprofile guides did it, by saying that the API is included in the microprofile dependency
  • e.g. https://github.com/OpenLiberty/guide-microprofile-config/pull/115/files#diff-7bd4a925c695c2eb0eced3872b9b965fL109

[NimG98]

Addressed.