Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address usage of deprecated constructor 'VersionedTextDocumentIdentifier.<init>(Integer)' #1187

Open
1 task
dessina-devasia opened this issue Dec 16, 2024 · 1 comment · May be fixed by #1228
Open
1 task

Address usage of deprecated constructor 'VersionedTextDocumentIdentifier.<init>(Integer)' #1187

dessina-devasia opened this issue Dec 16, 2024 · 1 comment · May be fixed by #1228
Assignees
@anusreelakshmi934
Labels
Deprecated API's Deprecated API usage in LTI Deprecated from IJ 2024.1.7 low priority
Milestone
Next

Comments

@dessina-devasia
Copy link
Contributor

The deprecated constructor VersionedTextDocumentIdentifier.(Integer) is invoked in the following method:

  • TextEditConverter.convertToTextDocumentEdit(int)

This invocation needs to be addressed to ensure compatibility.
@dessina-devasia dessina-devasia added high priority Deprecated API's Deprecated API usage in LTI labels Dec 16, 2024
@dessina-devasia dessina-devasia added this to the Next milestone Dec 16, 2024
@dessina-devasia dessina-devasia mentioned this issue Dec 16, 2024
Open
22 tasks
@anusreelakshmi934
Copy link
Contributor

anusreelakshmi934 commented Jan 10, 2025 •
edited
Loading

The VersionedTextDocumentIdentifier() is marked as deprecated in version 2024.1.7. Although it is called within the TextEditConverter.convertToTextDocumentEdit(int) method, this method is not utilized anywhere in the code. So maybe this code can be cleaned up.

VersionedTextDocumentIdentifier.version changed from type int to Integer, thus can be null now. To resolve the deprication refer lsp4j/changelog documentation

@anusreelakshmi934 anusreelakshmi934 linked a pull request Jan 15, 2025 that will close this issue
Open
@anusreelakshmi934 anusreelakshmi934 self-assigned this Jan 17, 2025
@anusreelakshmi934 anusreelakshmi934 moved this from New Issues to In Review in Open Liberty Developer Experience Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anusreelakshmi934 anusreelakshmi934

Labels
Deprecated API's Deprecated API usage in LTI Deprecated from IJ 2024.1.7 low priority
Projects
Open Liberty Developer Experience
Status: In Review
Milestone
Next
2 participants
@anusreelakshmi934 @dessina-devasia