Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta EE 11: Support Jakarta RESTful Web Services 4.0 #18740

Open
16 of 49 tasks
jhanders34 opened this issue Sep 26, 2021 · 4 comments
Open
16 of 49 tasks

Jakarta EE 11: Support Jakarta RESTful Web Services 4.0 #18740

jhanders34 opened this issue Sep 26, 2021 · 4 comments
Assignees
Labels
Design Approved Epic Used to track Feature Epics that are following the UFO process ID Required in:JAX-RS In Progress Items that are in active development. jakartaEE11 target:beta The Epic or Issue is targetted for the next beta target:24007-beta team:Wendigo West

Comments

@jhanders34
Copy link
Member

jhanders34 commented Sep 26, 2021

Description

Implement the Jakarta RESTful Web Services 4.0 specification


Documents

When available, add links to required feature documents. Use "N/A" to mark particular documents which are not required by the feature.

  • Externally raised requests for enhancements:
    • Aha: Link to the Aha idea (also add a link to this issue in the Aha idea)
      • Feature owner adds label Aha idea
    • Open Liberty Feature Request: Link to the OL GH issue (also add a link to this issue in the Feature Request GH issue)
      • Feature owner adds label Requested feature
  • UFO: https://ibm.ent.box.com/file/1272096102747
  • FTS: Link to Feature Test Summary GH Issue
  • Beta Blog: Issue 28707
  • GA Blog: Link to GA Blog Post GH Issue

Process Overview

General Instructions

The process steps occur roughly in the order as presented. Process steps occasionally overlap.

Each process step has a number of tasks which must be completed or must be marked as not applicable ("N/A").

Unless otherwise indicated, the tasks are the responsibility of the Feature Owner or a Delegate of the Feature Owner.

If you need assistance, reach out to the OpenLiberty/release-architect.

Important: Labels are used to trigger particular steps and must be added as indicated.


Prioritization (Complete Before Development Starts)

The (OpenLiberty/chief-architect) and area leads are responsible for prioritizing the features and determining which features are being actively worked on.

Prioritization

  • Feature added to the "New" column of the Open Liberty project board
    • Epics can be added to the board in one of two ways:
      • From this issue, use the "Projects" section to select the appropriate project board.
      • From the appropriate project board click "Add card" and select your Feature Epic issue
  • Priority assigned
    • Attend the Liberty Backlog Prioritization meeting

Design (Complete Before Development Starts)

Design preliminaries determine whether a formal design, which will be provided by an Upcoming Feature Overview (UFO) document, must be created and reviewed. A formal design is required if the feature requires any of the following: UI, Serviceability, SVT, Performance testing, or non-trivial documentation/ID. Furthermore, each identified item places a blocking requirement on another team so it must be identified early in the process. The feature owner may check-off the item if they know it doesn't apply, but otherwise they should work with the focal point to determine what work, if any, will be necessary and make them aware of it.

Design Preliminaries

  • UI requirements identified, or N/A. (Feature owner and UI focal point)
  • Accessibility requirements identified, or N/A. (Feature owner and Accessibility focal point)
  • ID requirements identified, or N/A. (Feature owner and ID focal point)
    • Refer to Documenting Open Liberty.
    • Feature Owner adds label ID Required, if non-trivial documentation needs to be created by the ID team.
    • ID adds label ID Required - Trivial, if no design will be performed and only trivial ID updates are needed.
  • Serviceability requirements identified, or N/A. (Feature owner and Serviceability focal point)
  • SVT requirements identified, or N/A. (Feature owner and SVT focal point)
  • Performance testing requirements identified, or N/A. (Feature owner and Performance focal point)

Design

  • POC Design / UFO review requested.
    • Feature owner adds label Design Review Request
  • POC Design / UFO review scheduled.
    • Follow the instructions in POC-Forum repo
  • POC Design / UFO review completed.
  • POC / UFO Review follow-ons completed.
  • POC Design / UFO approval requested.
    • Feature owner adds label Design Approval Request
  • Design / UFO approved. (OpenLiberty/chief-architect) or N/A
    • (OpenLiberty/chief-architect) adds label Design Approved
    • Add the public link to the UFO in Box to the Documents section.
    • The UFO must always accurately reflect the final implementation of the feature. Any changes must be first approved. Afterwards, update the UFO by creating a copy of the original approved slide(s) at the end of the deck and prepend "OLD" to the title(s). A single updated copy of the slide(s) should take the original's place, and have its title(s) prepended with "UPDATED".

No Design

  • No Design requested.
    • Feature owner adds label No Design Approval Request
  • No Design / No UFO approved. (OpenLiberty/chief-architect) or N/A
    • Approver adds label No Design Approved
  • Feature / Capability stabilization or discontinuation or N/A
    • Feature owner adds label Product Management Approval Request and notifies OpenLiberty/product-management
    • Approver adds label Product Management Approved (OpenLiberty/product-management)
    • Note: For stabilized, superseded, and discontinued feature/capability, skip the Beta section of the template (you may delete it). Otherwise, proceed as normal.

FAT Documentation


Implementation

A feature must be prioritized before any implementation work may begin to be delivered (inaccessible/no-ship). However, a design focused approach should still be applied to features, and developers should think about the feature design prior to writing and delivering any code.
Besides being prioritized, a feature must also be socialized (or No Design Approved) before any beta code may be delivered. All new Liberty content must be inaccessible in our GA releases until it is Feature Complete by either marking it kind=noship or beta fencing it.
Code may not GA until this feature has obtained the Design Approved or No Design Approved label, along with all other tasks outlined in the GA section.

Feature Development Begins

  • Add the In Progress label

Legal and Translation

In order to avoid last minute blockers and significant disruptions to the feature, the legal items need to be done as early in the feature process as possible, either in design or as early into the development as possible. Similarly, translation is to be done concurrently with development. Both MUST be completed before Beta or GA is requested.

Legal (Complete before Feature Complete Date)

  • Changed or new open source libraries are cleared and approved, or N/A. (Legal Release Services/Cass Tucker/Release PM).

Innovation (Complete 1 week before Feature Complete Date)

  • Consider whether any aspects of the feature may be patentable. If any identified, disclosures have been submitted.

Translation (Complete by Feature Complete Date)

  • PII (Program Integrated Information) updates are merged (i.e. all English strings due for translation have been delivered), or N/A.

Beta

In order to facilitate early feedback from users, all new features and functionality should first be released as part of a beta release.

Beta Code

  • Beta fence the functionality
    • E.g. kind=beta, ibm:beta, ProductInfo.getBetaEdition()
  • Beta development complete and feature ready for inclusion in a beta release
    • Add label target:beta and the appropriate target:YY00X-beta (where YY00X is the targeted beta version).
  • Feature delivered into beta

Beta Blog (Complete by beta eGA)

  • Beta blog issue created and populated using the Open Liberty BETA blog post template.
    • Add a link to the beta blog issue in the Documents section.
    • Note: This is for inclusion into the overall beta release blog post. If, in addition, you'd also like to create a dedicated blog post about your feature, then follow the "Standalone Feature Blog Post" instructions under the Other Deliverables section.

GA

A feature is ready to GA after it is Feature Complete and has obtained all necessary Focal Point Approvals.

Feature Complete

  • Feature implementation and tests completed.
    • All PRs are merged.
    • All related/child issues are closed.
    • All stop ship issues are completed.
  • Legal: all necessary approvals granted.
  • Translation: Feature may only proceed to GA if it has either Translation - Complete or Translation - Missing label
    • If all translation has been delivered to release branch, feature owner adds label Translation - Complete.
    • If missing translation does not cause a break in functionality, nor a security or production outage risk, feature owner adds label Translation - Missing.
      • Once all missing translations are delivered, the Translation - Missing label is replaced with Translation - Complete.
    • If missing translation could cause a break in functionality or a security or production outage risk, feature owner adds the Translation - Blocked label.
      • Featues with Translation - Blocked may NOT proceed to GA until the label has been replaced with either Translation - Missing or Translation - Complete.
    • For further guidance, contact Globalization focal point or the Release Architect.
  • GA development complete and feature ready for inclusion in a GA release
    • Add label target:ga and the appropriate target:YY00X (where YY00X is the targeted GA version).
    • Inclusion in a release requires the completion of all Focal Point Approvals.

Focal Point Approvals (Complete by Feature Complete Date)

These occur only after GA of this feature is requested (by adding a target:ga label). GA of this feature may not occur until all approvals are obtained.

All Features

  • APIs/Externals - Externals have been reviewed or N/A. (OpenLiberty/externals-approvers)
    • Approver adds label focalApproved:externals
  • Demo - Demo is scheduled for an upcoming EOI or N/A. (OpenLiberty/demo-approvers)
    • Add comment @OpenLiberty/demo-approvers Demo scheduled for EOI [Iteration Number] to this issue.
    • Approver adds label focalApproved:demo.
  • FAT - All Tests complete and running successfully in SOE or N/A. (OpenLiberty/fat-approvers)
    • Approver adds label focalApproved:fat.

Design Approved Features

  • ID - Documentation is complete or N/A. (OpenLiberty/id-approvers)
    • Approver adds label focalApproved:id.
    • NOTE: If only trivial documentation changes are required, you may reach out to the ID Feature Focal to request a ID Required - Trivial label. Unlike features with regular ID requirement, those with ID Required - Trivial label do not have a hard requirement for a Design/UFO.

  • InstantOn - InstantOn capable or N/A. (OpenLiberty/instantOn-approvers)
    • Approver adds label focalApproved:instantOn.
  • Performance - Performance testing is complete or N/A. (OpenLiberty/performance-approvers)
    • Approver adds label focalApproved:performance.
  • Serviceability - Serviceability has been addressed or N/A. (OpenLiberty/serviceability-approvers)
    • Approver adds label focalApproved:sve.
  • STE - Skills Transfer Education chart deck is complete or N/A. (OpenLiberty/ste-approvers)
    • Approver adds label focalApproved:ste.
  • SVT - System Verification Test is complete or N/A. (OpenLiberty/svt-approvers)
    • Approver adds label focalApproved:svt.

Remove Beta Fencing (Complete by Feature Complete Date)

  • Beta guards are removed, or N/A
    • Only after all necessary Focal Point Approvals have been granted.

GA Blog (Complete by Friday after GM)

  • GA Blog issue created and populated using the Open Liberty GA release blog post template.
    • Add a link to the GA Blog issue in the Documents section.
    • Note: This is for inclusion into the overall release blog post. If, in addition, you'd also like to create a dedicated blog post about your feature, then follow the "Standalone Feature Blog Post" instructions under the Other Deliverables section.

Post GM (Complete before GA)

  • After confirming this feature has been included in the GM driver, feature owner closes this issue.

Post GA


Other Deliverables


@jhanders34 jhanders34 added in:JAX-RS Epic Used to track Feature Epics that are following the UFO process team:Wendigo West jakartaEE10 labels Sep 26, 2021
@kwsutter
Copy link

Just an FYI... JAX-RS 4.0 is post Jakarta EE 10. The Jakarta EE 10 Release Plan identifies JAX-RS 3.1 as part of Jakarta EE 10. The 4.0 release is planned for after Jakarta EE 10.

@jhanders34 jhanders34 changed the title Jakarta EE 10: Support Jakarta RESTful Web Services 4.0 Support Jakarta RESTful Web Services 4.0 Oct 12, 2021
@andymc12 andymc12 assigned WhiteCat22 and jim-krueger and unassigned andymc12 Dec 14, 2021
@malincoln malincoln added In Progress Items that are in active development. and removed In Progress Items that are in active development. labels Sep 30, 2022
@jhanders34 jhanders34 changed the title Support Jakarta RESTful Web Services 4.0 Jakarta EE 11: Support Jakarta RESTful Web Services 4.0 Mar 24, 2023
@neuwerk
Copy link
Member

neuwerk commented Sep 6, 2023

Notes from UFO socialization:

Slide 10:

  • Scoped annotations require a no parameter constructor
  • Add a list of all @<Params> annotation

Slide 12:

  • Lots of discussion around possible alternatives for the naming of @Entity. Since there is naming overlap with other existing specs that have an @Enity annotation, we should push for a name change. Several were floated but something like @PayloadEntity should be considered, to distinguish that it could be both request/response and that it’s related to the content of the message.
  • Jakarta Rest Issue 1183

Slide 14:

  • Notate that exactly one @Application annotation can be used.

Slide 15:

  • Zero Application subclasses being a must should be pushed for

Slide 17:

  • Will there be negative tests for full CDI to make sure it’s not CDI-Light?

Slides 18/19 and all other instances:

  • Replace JAXB with XML Binding

Slide 24:

  • Include design of resfulWSClient-4.0 feature.

Slide 25:

  • Graphical slide for the feature design. Something understandable and shareable with user. (Include how the Client-4.0 feature fits into this too)

Slide 29:

  • Note that it could impacted existing APIs and changes could be needed

Slide 30:

  • Feature config?

Slide 33:

  • Similar to 29, if the changes could impact the monitor features they’d need to tolerate it.

Slide 35:

  • Add the required Resteasy info, licensing etc. Add the same for the Restful Spec projects

Slide 37:

  • Some discussion on how to best extend old tests for new tests and revisiting the repeat rules, but nothing firm decided

Slide 40:

  • Only Java 21

Slide 42:

  • Remove all references to queues and specific and internal support info

@WhiteCat22
Copy link
Member

Opened jakartaee/rest#1183 to discuss renaming the new @Entity annotation

@NottyCode NottyCode changed the title Jakarta EE 11: Support Jakarta RESTful Web Services 4.0 Jakarta EE 11: Support Jakarta RESTful Web Services 3.2/4.0 Jan 24, 2024
@jhanders34 jhanders34 changed the title Jakarta EE 11: Support Jakarta RESTful Web Services 3.2/4.0 Jakarta EE 11: Support Jakarta RESTful Web Services 4.0 Feb 28, 2024
@jim-krueger jim-krueger added target:beta The Epic or Issue is targetted for the next beta target:24007-beta labels May 29, 2024
@LifeIsGood524 LifeIsGood524 added the In Progress Items that are in active development. label May 30, 2024
@scottkurz
Copy link
Contributor

scottkurz commented Jun 17, 2024

Notes from UFO socialization (part 2):

  1. slide 3
  • Apha2 -> Alpha2
  1. slide 17
  • include return value type with getMatchedResourceTemplate() signature
  • what is a "matrix" parm?
  1. slide 24
  • Let's use a different term than "convenience feature" maybe "convenience API" or utility API or something
  1. slide 27
  • Brought up concerns of ManagedBean and JAXB dependency removal but agreed they were dealt with by Migration
  1. slide 32
  • Mention the API project too along w/ RESTEasy
  • Mention we'll use a version like "7.0.0.Final"
  1. slide 34
  • add InstantOn repeat rules
  • add TCK execution
  1. slide 37
  • should say Java 17 and 21
  1. slide 41
  • concern raised on ManagedBean removal - thought was it was basically unused (so not a high priority)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Approved Epic Used to track Feature Epics that are following the UFO process ID Required in:JAX-RS In Progress Items that are in active development. jakartaEE11 target:beta The Epic or Issue is targetted for the next beta target:24007-beta team:Wendigo West
Projects
Development

No branches or pull requests

10 participants