Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect the workarea of the server for different launch scenarios #7491

Closed
tjwatson opened this issue May 10, 2019 · 1 comment · Fixed by #8804
Closed

Protect the workarea of the server for different launch scenarios #7491

tjwatson opened this issue May 10, 2019 · 1 comment · Fixed by #8804

Comments

@tjwatson
Copy link
Member

See #7448 for failing scenario

If the installUtility is used against a server configuration then it will use the persistent workarea of the server and potentially trash some of the cached data in it. For the failing issue above the persisted configuration Dictionary data was being deleted by running the installUtility against the server configuration (perhaps another bug to fix?).

In the past there have been other cases where this behavior of sharing the workarea store for the different launch scenarios has caused us issues (Alasdair to inject cases he knows about here). I can think of the following ways to address this:

  1. Fix all cases to avoid trashing the workarea persistent data, for example, don't cause the persistent configuration Dictionary data files to be deleted as a side effect of running installUtility
  2. Partition the workarea for different launch scenarios. For example, the runtime would have a subfolder workarea/runtime, the installUtility could have workarea/install, minify/package server would have workarea/package etc.
  3. Have everything that uses the server workarea/ folder besides the actual runtime to invalidate the cache causing an implicit --clean, similar to how the fingerprint file is used for installing iFixes.
@NottyCode
Copy link
Member

We should do #2 as the safest option. The default location for a workarea must not be the location the server runs from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Implemented
Development

Successfully merging a pull request may close this issue.

3 participants