From 2e84f76f8a85e6c2575affcbd7e18bad976c7a5d Mon Sep 17 00:00:00 2001 From: rfeese Date: Fri, 30 Dec 2022 13:35:37 -0600 Subject: [PATCH] Added autocomplete attribute to known password fields (#2700) --- .all-contributorsrc | 9 +++++++++ README.md | 1 + .../base/default/template/checkout/onepage/billing.phtml | 5 +++-- .../base/default/template/checkout/onepage/login.phtml | 2 +- .../default/template/customer/form/changepassword.phtml | 7 ++++--- .../base/default/template/customer/form/edit.phtml | 7 ++++--- .../base/default/template/customer/form/login.phtml | 2 +- .../base/default/template/customer/form/mini.login.phtml | 4 ++-- .../base/default/template/customer/form/register.phtml | 5 +++-- .../template/customer/form/resetforgottenpassword.phtml | 5 +++-- .../template/oauth/authorize/form/login-simple.phtml | 2 +- .../default/template/oauth/authorize/form/login.phtml | 2 +- .../template/persistent/checkout/onepage/billing.phtml | 5 +++-- .../template/persistent/checkout/onepage/login.phtml | 2 +- .../template/persistent/customer/form/login.phtml | 2 +- .../template/persistent/customer/form/register.phtml | 5 +++-- .../default/iphone/template/customer/form/login.phtml | 2 +- .../template/persistent/checkout/onepage/login.phtml | 2 +- .../iphone/template/persistent/customer/form/login.phtml | 2 +- .../default/template/customer/form/changepassword.phtml | 7 ++++--- .../rwd/default/template/customer/form/edit.phtml | 7 ++++--- .../rwd/default/template/customer/form/mini.login.phtml | 4 ++-- .../template/customer/form/resetforgottenpassword.phtml | 5 +++-- .../template/oauth/authorize/form/login-simple.phtml | 2 +- .../template/persistent/checkout/onepage/billing.phtml | 5 +++-- .../template/persistent/checkout/onepage/login.phtml | 2 +- .../template/persistent/customer/form/login.phtml | 2 +- .../template/persistent/customer/form/register.phtml | 5 +++-- 28 files changed, 66 insertions(+), 44 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index eabd644b004..443cc3ae4ec 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1351,6 +1351,15 @@ "contributions": [ "code" ] + }, + { + "login": "rfeese", + "name": "Roger Feese", + "avatar_url": "https://avatars.githubusercontent.com/u/7074181?v=4", + "profile": "https://github.com/rfeese", + "contributions": [ + "code" + ] } ], "contributorsPerLine": 7 diff --git a/README.md b/README.md index 4c96da6b471..206892f3cfa 100644 --- a/README.md +++ b/README.md @@ -450,6 +450,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
Enéias Ramos de Melo

Scott Moore
+
Roger Feese
diff --git a/app/design/frontend/base/default/template/checkout/onepage/billing.phtml b/app/design/frontend/base/default/template/checkout/onepage/billing.phtml index 3588e8b3026..ae6f9de9646 100644 --- a/app/design/frontend/base/default/template/checkout/onepage/billing.phtml +++ b/app/design/frontend/base/default/template/checkout/onepage/billing.phtml @@ -159,7 +159,8 @@ name="billing[customer_password]" id="billing:customer_password" title="quoteEscape($this->__('Password')) ?>" - class="input-text required-entry validate-password min-pass-length-" /> + class="input-text required-entry validate-password min-pass-length-" + autocomplete="off" />

__('The minimum password length is %s', $minPasswordLength) ?>

@@ -168,7 +169,7 @@
- +
diff --git a/app/design/frontend/base/default/template/checkout/onepage/login.phtml b/app/design/frontend/base/default/template/checkout/onepage/login.phtml index 723089c0989..ba6f4f6743e 100644 --- a/app/design/frontend/base/default/template/checkout/onepage/login.phtml +++ b/app/design/frontend/base/default/template/checkout/onepage/login.phtml @@ -74,7 +74,7 @@
  • - +
  • getChildHtml('form.additional.info'); ?> diff --git a/app/design/frontend/base/default/template/customer/form/changepassword.phtml b/app/design/frontend/base/default/template/customer/form/changepassword.phtml index 3af1b8e635c..8381eb085e6 100644 --- a/app/design/frontend/base/default/template/customer/form/changepassword.phtml +++ b/app/design/frontend/base/default/template/customer/form/changepassword.phtml @@ -29,7 +29,7 @@
  • - +
  • @@ -41,7 +41,8 @@ title="quoteEscape($this->__('New Password')) ?>" class="input-text required-entry validate-password min-pass-length-" name="password" - id="password" /> + id="password" + autocomplete="new-password" />

    __('The minimum password length is %s', $minPasswordLength) ?>

    @@ -50,7 +51,7 @@
    - +
  • diff --git a/app/design/frontend/base/default/template/customer/form/edit.phtml b/app/design/frontend/base/default/template/customer/form/edit.phtml index 7407ec55923..e15f5ce928b 100644 --- a/app/design/frontend/base/default/template/customer/form/edit.phtml +++ b/app/design/frontend/base/default/template/customer/form/edit.phtml @@ -54,7 +54,7 @@
    - +
  • @@ -74,7 +74,8 @@ title="quoteEscape($this->__('New Password')) ?>" class="input-text required-entry validate-password min-pass-length-" name="password" - id="password" /> + id="password" + autocomplete="new-password" />

    __('The minimum password length is %s', $minPasswordLength) ?>

    @@ -83,7 +84,7 @@
    - +
  • diff --git a/app/design/frontend/base/default/template/customer/form/login.phtml b/app/design/frontend/base/default/template/customer/form/login.phtml index 044fda4d006..3a083532ce6 100644 --- a/app/design/frontend/base/default/template/customer/form/login.phtml +++ b/app/design/frontend/base/default/template/customer/form/login.phtml @@ -56,7 +56,7 @@
  • - +
  • getChildHtml('form.additional.info'); ?> diff --git a/app/design/frontend/base/default/template/customer/form/mini.login.phtml b/app/design/frontend/base/default/template/customer/form/mini.login.phtml index cb7235301ee..98e2bfb10af 100644 --- a/app/design/frontend/base/default/template/customer/form/mini.login.phtml +++ b/app/design/frontend/base/default/template/customer/form/mini.login.phtml @@ -33,11 +33,11 @@ getBlockHtml('formkey') ?>
    - +
    - \ No newline at end of file + diff --git a/app/design/frontend/base/default/template/customer/form/register.phtml b/app/design/frontend/base/default/template/customer/form/register.phtml index 0adbe643c5f..8f0cccc8bd4 100644 --- a/app/design/frontend/base/default/template/customer/form/register.phtml +++ b/app/design/frontend/base/default/template/customer/form/register.phtml @@ -161,7 +161,8 @@ name="password" id="password" title="quoteEscape($this->__('Password')) ?>" - class="input-text required-entry validate-password min-pass-length-" /> + class="input-text required-entry validate-password min-pass-length-" + autocomplete="off" />

    __('The minimum password length is %s', $minPasswordLength) ?>

    @@ -170,7 +171,7 @@
    - +
    diff --git a/app/design/frontend/base/default/template/customer/form/resetforgottenpassword.phtml b/app/design/frontend/base/default/template/customer/form/resetforgottenpassword.phtml index 365b56e200d..d4c31d6ddbb 100644 --- a/app/design/frontend/base/default/template/customer/form/resetforgottenpassword.phtml +++ b/app/design/frontend/base/default/template/customer/form/resetforgottenpassword.phtml @@ -33,7 +33,8 @@ + id="password" + autocomplete="off" />

    __('The minimum password length is %s', $minPasswordLength); ?>

    @@ -42,7 +43,7 @@
    - +
    diff --git a/app/design/frontend/base/default/template/oauth/authorize/form/login-simple.phtml b/app/design/frontend/base/default/template/oauth/authorize/form/login-simple.phtml index 2a5cd92d582..0dc830a930f 100644 --- a/app/design/frontend/base/default/template/oauth/authorize/form/login-simple.phtml +++ b/app/design/frontend/base/default/template/oauth/authorize/form/login-simple.phtml @@ -52,7 +52,7 @@ * __('Password') ?> + value="" autocomplete="off" />
    - \ No newline at end of file + diff --git a/app/design/frontend/rwd/default/template/customer/form/resetforgottenpassword.phtml b/app/design/frontend/rwd/default/template/customer/form/resetforgottenpassword.phtml index 2577eca61dd..653b9dc020f 100644 --- a/app/design/frontend/rwd/default/template/customer/form/resetforgottenpassword.phtml +++ b/app/design/frontend/rwd/default/template/customer/form/resetforgottenpassword.phtml @@ -34,7 +34,8 @@ + id="password" + autocomplete="new-password" />

    __('The minimum password length is %s', $minPasswordLength); ?>

    @@ -43,7 +44,7 @@
    - +
    diff --git a/app/design/frontend/rwd/default/template/oauth/authorize/form/login-simple.phtml b/app/design/frontend/rwd/default/template/oauth/authorize/form/login-simple.phtml index d1ca0941031..29d8fa1fe44 100644 --- a/app/design/frontend/rwd/default/template/oauth/authorize/form/login-simple.phtml +++ b/app/design/frontend/rwd/default/template/oauth/authorize/form/login-simple.phtml @@ -52,7 +52,7 @@ * __('Password') ?> + value="" autocomplete="off" />