diff --git a/lib/Mage/Archive.php b/lib/Mage/Archive.php index 1e16b5c2ca3..584d5030e38 100644 --- a/lib/Mage/Archive.php +++ b/lib/Mage/Archive.php @@ -40,7 +40,7 @@ class Mage_Archive /** * Current archiver is used for compress. * - * @var Mage_Archiver_Tar|Mage_Archiver_Gz|Mage_Archiver_Bz + * @var Mage_Archive_Tar|Mage_Archive_Gz|Mage_Archive_Bz */ protected $_archiver = null; @@ -68,7 +68,7 @@ class Mage_Archive * Create object of current archiver by $extension. * * @param string $extension - * @return Mage_Archiver_Tar|Mage_Archiver_Gz|Mage_Archiver_Bz + * @return Mage_Archive_Tar|Mage_Archive_Gz|Mage_Archive_Bz */ protected function _getArchiver($extension) { diff --git a/lib/Mage/Archive/Helper/File.php b/lib/Mage/Archive/Helper/File.php index 8035bc8b7cd..46e8efd143c 100644 --- a/lib/Mage/Archive/Helper/File.php +++ b/lib/Mage/Archive/Helper/File.php @@ -58,7 +58,7 @@ class Mage_Archive_Helper_File /** * File handler * - * @var pointer + * @var resource|false pointer */ protected $_fileHandler; diff --git a/lib/Mage/Archive/Tar.php b/lib/Mage/Archive/Tar.php index 9f03c8f894e..1e56cd21533 100644 --- a/lib/Mage/Archive/Tar.php +++ b/lib/Mage/Archive/Tar.php @@ -60,14 +60,14 @@ class Mage_Archive_Tar extends Mage_Archive_Abstract implements Mage_Archive_Int /** * Tarball data writer * - * @var Mage_Archive_Helper_File + * @var Mage_Archive_Helper_File|null */ protected $_writer; /** * Tarball data reader * - * @var Mage_Archive_Helper_File + * @var Mage_Archive_Helper_File|null */ protected $_reader; @@ -261,7 +261,7 @@ protected function _packToTar($skipRoot = false) if (!$skipRoot) { $header = $this->_composeHeader(); $data = $this->_readFile($file); - $data = str_pad($data, floor(((is_dir($file) ? 0 : filesize($file)) + 512 - 1) / 512) * 512, "\0"); + $data = str_pad($data, intval(((is_dir($file) ? 0 : filesize($file)) + 512 - 1) / 512) * 512, "\0"); } $sub = ''; if (is_dir($file)) { @@ -276,7 +276,7 @@ protected function _packToTar($skipRoot = false) } } $tarData = $header . $data . $sub; - $tarData = str_pad($tarData, floor((strlen($tarData) - 1) / 1536) * 1536, "\0"); + $tarData = str_pad($tarData, intval((strlen($tarData) - 1) / 1536) * 1536, "\0"); return $tarData; } @@ -364,7 +364,7 @@ protected function _composeHeader($long = false) $longHeader = ''; if (!$long && strlen($nameFile) > 100) { $longHeader = $this->_composeHeader(true); - $longHeader .= str_pad($nameFile, floor((strlen($nameFile) + 512 - 1) / 512) * 512, "\0"); + $longHeader .= str_pad($nameFile, intval((strlen($nameFile) + 512 - 1) / 512) * 512, "\0"); } $header = []; $header['100-name'] = $long ? '././@LongLink' : substr($nameFile, 0, 100); @@ -462,7 +462,7 @@ protected function _unpackCurrentTar($destination) * * @deprecated after 1.7.0.0 * @param resource $pointer - * @return string + * @return array|false */ protected function _parseHeader(&$pointer) { @@ -497,13 +497,13 @@ protected function _parseHeader(&$pointer) $checksumOk = $header['checksum'] == $checksum; if (isset($header['name']) && $checksumOk) { if ($header['name'] == '././@LongLink' && $header['type'] == 'L') { - $realName = substr(fread($pointer, floor(($header['size'] + 512 - 1) / 512) * 512), 0, $header['size']); + $realName = substr(fread($pointer, intval(($header['size'] + 512 - 1) / 512) * 512), 0, $header['size']); $headerMain = $this->_parseHeader($pointer); $headerMain['name'] = $realName; return $headerMain; } else { if ($header['size'] > 0) { - $header['data'] = substr(fread($pointer, floor(($header['size'] + 512 - 1) / 512) * 512), 0, $header['size']); + $header['data'] = substr(fread($pointer, intval(($header['size'] + 512 - 1) / 512) * 512), 0, $header['size']); } else { $header['data'] = ''; } @@ -555,7 +555,7 @@ protected function _extractFileHeader() return $header; } - $realNameBlockSize = floor(($header['size'] + self::TAR_BLOCK_SIZE - 1) / self::TAR_BLOCK_SIZE) + $realNameBlockSize = intval(($header['size'] + self::TAR_BLOCK_SIZE - 1) / self::TAR_BLOCK_SIZE) * self::TAR_BLOCK_SIZE; $realNameBlock = $archiveReader->read($realNameBlockSize); $realName = substr($realNameBlock, 0, $header['size']); @@ -662,7 +662,7 @@ public function extract($file, $source, $destination) } if ($header['type'] != 5) { - $skipBytes = floor(($header['size'] + self::TAR_BLOCK_SIZE - 1) / self::TAR_BLOCK_SIZE) + $skipBytes = intval(($header['size'] + self::TAR_BLOCK_SIZE - 1) / self::TAR_BLOCK_SIZE) * self::TAR_BLOCK_SIZE; $archiveReader->read($skipBytes); } diff --git a/lib/Mage/Backup.php b/lib/Mage/Backup.php index 89d3e47df99..3716a876ac8 100644 --- a/lib/Mage/Backup.php +++ b/lib/Mage/Backup.php @@ -38,7 +38,7 @@ class Mage_Backup * get Backup Instance By File Name * * @param string $type - * @return Mage_Backup_Interface + * @return Mage_Backup_Db|Mage_Backup_Interface */ public static function getBackupInstance($type) { diff --git a/lib/Mage/Backup/Abstract.php b/lib/Mage/Backup/Abstract.php index 8b9e171e4ae..28aedc371d6 100644 --- a/lib/Mage/Backup/Abstract.php +++ b/lib/Mage/Backup/Abstract.php @@ -252,7 +252,6 @@ public function getErrorMessage() * Set error message * * @param string $errorMessage - * @return string */ public function setErrorMessage($errorMessage) { diff --git a/lib/Mage/Backup/Archive/Tar.php b/lib/Mage/Backup/Archive/Tar.php index 7b8d2703818..47a451db6f5 100644 --- a/lib/Mage/Backup/Archive/Tar.php +++ b/lib/Mage/Backup/Archive/Tar.php @@ -67,7 +67,7 @@ protected function _createTar($skipRoot = false, $finalize = false) * Set files that shouldn't be added to tarball * * @param array $skipFiles - * @return Mage_Backup_Archive_Tar + * @return $this */ public function setSkipFiles(array $skipFiles) { diff --git a/lib/Mage/Backup/Filesystem.php b/lib/Mage/Backup/Filesystem.php index aa9296f3999..c7dcffd5225 100644 --- a/lib/Mage/Backup/Filesystem.php +++ b/lib/Mage/Backup/Filesystem.php @@ -73,7 +73,6 @@ class Mage_Backup_Filesystem extends Mage_Backup_Abstract * Implementation Rollback functionality for Filesystem * * @throws Mage_Exception - * @return bool */ public function rollback() { diff --git a/lib/Mage/Backup/Interface.php b/lib/Mage/Backup/Interface.php index 6b877755fa2..81d36a66289 100644 --- a/lib/Mage/Backup/Interface.php +++ b/lib/Mage/Backup/Interface.php @@ -37,7 +37,7 @@ public function create(); /** * Rollback Backup * - * @return boolean + * @return bool */ public function rollback(); diff --git a/lib/Mage/Backup/Nomedia.php b/lib/Mage/Backup/Nomedia.php index af3216d9c45..619910acfbd 100644 --- a/lib/Mage/Backup/Nomedia.php +++ b/lib/Mage/Backup/Nomedia.php @@ -65,7 +65,7 @@ public function getType() /** * Add media folder to ignore list * - * @return Mage_Backup_Media + * @return $this */ protected function _prepareIgnoreList() { diff --git a/lib/Mage/Backup/Snapshot.php b/lib/Mage/Backup/Snapshot.php index bcb5a11b123..d525188c7c0 100644 --- a/lib/Mage/Backup/Snapshot.php +++ b/lib/Mage/Backup/Snapshot.php @@ -30,7 +30,7 @@ class Mage_Backup_Snapshot extends Mage_Backup_Filesystem /** * Database backup manager * - * @var Mage_Backup_Db + * @var Mage_Backup_Interface|Mage_Backup_Db|null */ protected $_dbBackupManager; @@ -111,7 +111,7 @@ protected function _createDbBackupInstance() /** * Get database backup manager * - * @return Mage_Backup_Db + * @return Mage_Backup_Interface */ protected function _getDbBackupManager() { @@ -125,7 +125,7 @@ protected function _getDbBackupManager() /** * Remove Db backup after added it to the snapshot * - * @return Mage_Backup_Snapshot + * @return $this */ protected function _removeDbBackup() { diff --git a/lib/Mage/DB/Mysqli.php b/lib/Mage/DB/Mysqli.php index cc4dad4f89b..9ac94f32d6b 100644 --- a/lib/Mage/DB/Mysqli.php +++ b/lib/Mage/DB/Mysqli.php @@ -42,7 +42,7 @@ class Mage_DB_Mysqli /** * Value escaper - * @var unknown_type + * @var string */ public const VALUE_ESCAPER = '"'; @@ -53,7 +53,7 @@ class Mage_DB_Mysqli protected $conn; /** * Fetch mode - * @var unknown_type + * @var int */ private $fetch_mode = MYSQLI_ASSOC; @@ -117,7 +117,7 @@ public function escapeTableName($table) /** * Escape field name - * @param stirng $fld + * @param string $fld * @return string */ public function escapeFieldName($fld) @@ -312,7 +312,7 @@ protected function throwConnectException() /** * Query - perform with throwing exception on error - * @param sting $sql query + * @param string $sql query * @throws Mage_DB_Exception * @return mixed */ diff --git a/lib/Mage/HTTP/Client.php b/lib/Mage/HTTP/Client.php index f49b86c68af..cafb59b9cd5 100644 --- a/lib/Mage/HTTP/Client.php +++ b/lib/Mage/HTTP/Client.php @@ -38,7 +38,7 @@ private function __construct() /** * Factory for HTTP client - * @param string/false $frontend 'curl'/'socket' or false for auto-detect + * @param string|false $frontend 'curl'/'socket' or false for auto-detect * @return Mage_HTTP_IClient */ public static function getInstance($frontend = false) @@ -59,7 +59,7 @@ public static function getInstance($frontend = false) * Detects frontend type. * Priority is given to CURL * - * @return string/bool + * @return string|false */ protected static function detectFrontend() { diff --git a/lib/Mage/HTTP/Client/Curl.php b/lib/Mage/HTTP/Client/Curl.php index 76f42513421..1b30a1ac0e9 100644 --- a/lib/Mage/HTTP/Client/Curl.php +++ b/lib/Mage/HTTP/Client/Curl.php @@ -329,7 +329,6 @@ public function getStatus() * @param string $method * @param string $uri * @param array|string $params pass an array to form post, pass a json encoded string to directly post json - * @return null */ protected function makeRequest($method, $uri, $params = []) { @@ -465,8 +464,8 @@ protected function validateHttpVersion(array $line) /** * Set curl option directly * - * @param string $name - * @param string $value + * @param int $name + * @param int|array|string $value */ protected function curlOption($name, $value) { diff --git a/lib/Mage/HTTP/Client/Socket.php b/lib/Mage/HTTP/Client/Socket.php index c9d74870fe0..96fe7ac17d3 100644 --- a/lib/Mage/HTTP/Client/Socket.php +++ b/lib/Mage/HTTP/Client/Socket.php @@ -42,7 +42,7 @@ class Mage_HTTP_Client_Socket implements Mage_HTTP_IClient /** * Stream resource - * @var object + * @var resource */ private $_sock = null; @@ -437,7 +437,6 @@ public function getStatus() * @param string $method * @param string $uri * @param array $params - * @return null */ protected function makeRequest($method, $uri, $params = []) { diff --git a/lib/Mage/HTTP/IClient.php b/lib/Mage/HTTP/IClient.php index 5a79b3a86d8..68e0720d5ec 100644 --- a/lib/Mage/HTTP/IClient.php +++ b/lib/Mage/HTTP/IClient.php @@ -87,7 +87,7 @@ public function removeCookies(); /** * Make GET request - * @param string full uri + * @param string $uri full uri */ public function get($uri); diff --git a/lib/Mage/System/Args.php b/lib/Mage/System/Args.php index 3fa3d489b67..b17968387ca 100644 --- a/lib/Mage/System/Args.php +++ b/lib/Mage/System/Args.php @@ -46,15 +46,15 @@ public function getFiltered() /** * Constructor - * @param array $argv, if false $GLOBALS['argv'] is taken + * @param array|false $argv, if false $GLOBALS['argv'] is taken * @return void */ - public function __construct($source = false) + public function __construct($argv = false) { $this->flags = []; $this->filtered = []; - if (false === $source) { + if (false === $argv) { $argv = $GLOBALS['argv']; array_shift($argv); } diff --git a/lib/Mage/System/Ftp.php b/lib/Mage/System/Ftp.php index 2abc1f239aa..2e0e9c0384a 100644 --- a/lib/Mage/System/Ftp.php +++ b/lib/Mage/System/Ftp.php @@ -31,7 +31,7 @@ class Mage_System_Ftp /** * Connection object * - * @var resource + * @var resource|false */ protected $_conn = false; @@ -51,8 +51,8 @@ protected function checkConnected() /** * ftp_mkdir wrapper * - * @param stin$name - * @return unknown_type + * @param string $name + * @return string */ public function mdkir($name) { @@ -111,7 +111,7 @@ public function login($login = "anonymous", $password = "test@gmail.com") * * @param string $string * @throws Exception - * @return string + * @return array */ public function validateConnectionString($string) { @@ -225,24 +225,24 @@ public function raw($cmd) * Can be used for relative and absoulte remote paths * Relative: use chdir before calling this * - * @param srting $remote + * @param string $remote * @param string $local * @param int $dirMode * @param int $ftpMode - * @return unknown_type + * @return bool */ public function upload($remote, $local, $dirMode = 0777, $ftpMode = FTP_BINARY) { $this->checkConnected(); if (!file_exists($local)) { - throw new Exception("Local file doesn't exist: {$localFile}"); + throw new Exception("Local file doesn't exist: {$local}"); } if (!is_readable($local)) { - throw new Exception("Local file is not readable: {$localFile}"); + throw new Exception("Local file is not readable: {$local}"); } if (is_dir($local)) { - throw new Exception("Directory given instead of file: {$localFile}"); + throw new Exception("Directory given instead of file: {$local}"); } $globalPathMode = substr($remote, 0, 1) == "/"; diff --git a/lib/Mage/Xml/Generator.php b/lib/Mage/Xml/Generator.php index 73541483875..8b71989bd57 100644 --- a/lib/Mage/Xml/Generator.php +++ b/lib/Mage/Xml/Generator.php @@ -28,19 +28,28 @@ public function __construct() $this->_dom = new DOMDocument('1.0'); $this->_dom->formatOutput = true; $this->_currentDom = $this->_dom; - return $this; } + /** + * @return DOMDocument|null + */ public function getDom() { return $this->_dom; } + /** + * @return DOMElement + */ protected function _getCurrentDom() { return $this->_currentDom; } + /** + * @param DOMElement $node + * @return $this + */ protected function _setCurrentDom($node) { $this->_currentDom = $node; @@ -48,7 +57,7 @@ protected function _setCurrentDom($node) } /** - * @param array $content + * @param array|array[] $content */ public function arrayToXml($content) { @@ -95,11 +104,18 @@ public function arrayToXml($content) return $this; } + /** + * @return string + */ public function __toString() { return $this->getDom()->saveXML(); } + /** + * @param string $file + * @return $this + */ public function save($file) { $this->getDom()->save($file); diff --git a/lib/Mage/Xml/Parser.php b/lib/Mage/Xml/Parser.php index 063da30868f..7239c06bb69 100644 --- a/lib/Mage/Xml/Parser.php +++ b/lib/Mage/Xml/Parser.php @@ -27,7 +27,6 @@ public function __construct() { $this->_dom = new DOMDocument(); $this->_currentDom = $this->_dom; - return $this; } public function getDom() diff --git a/lib/Magento/Db/Adapter/Pdo/Mysql.php b/lib/Magento/Db/Adapter/Pdo/Mysql.php index b6c0dd238d4..b4e0e23b834 100644 --- a/lib/Magento/Db/Adapter/Pdo/Mysql.php +++ b/lib/Magento/Db/Adapter/Pdo/Mysql.php @@ -104,8 +104,8 @@ public function splitSelect(Varien_Db_Select $select, $entityIdField = '*', $ste /** * Quote a raw string. * - * @param string $value Raw string - * @return string Quoted string + * @param string|float $value Raw string + * @return string|float Quoted string */ protected function _quote($value) { @@ -132,7 +132,7 @@ public function quote($value, $type = null) $this->_connect(); if ($type !== null - && rray_key_exists($type = strtoupper($type), $this->_numericDataTypes) + && array_key_exists($type = strtoupper($type), $this->_numericDataTypes) && $this->_numericDataTypes[$type] == Zend_Db::FLOAT_TYPE ) { $value = $this->_convertFloat($value); diff --git a/lib/Magento/Profiler.php b/lib/Magento/Profiler.php index 73705ad7e80..9a23c5fc490 100644 --- a/lib/Magento/Profiler.php +++ b/lib/Magento/Profiler.php @@ -275,7 +275,7 @@ public static function display() if (!self::$_enabled) { return; } - /** @var $output Magento_Profiler_OutputAbstract */ + /** @var Magento_Profiler_OutputAbstract $output */ foreach (self::$_outputs as $output) { $output->display(); } diff --git a/lib/Magento/Profiler/OutputAbstract.php b/lib/Magento/Profiler/OutputAbstract.php index c4ebe9af872..0ff565ff454 100644 --- a/lib/Magento/Profiler/OutputAbstract.php +++ b/lib/Magento/Profiler/OutputAbstract.php @@ -87,7 +87,7 @@ protected function _renderColumnValue($timerId, $columnId) if ($columnId == 'timer_id') { return $this->_renderTimerId($timerId); } - $value = (string)Magento_Profiler::fetch($timerId, $columnId); + $value = (float)Magento_Profiler::fetch($timerId, $columnId); if (in_array($columnId, [Magento_Profiler::FETCH_TIME, Magento_Profiler::FETCH_AVG])) { $value = number_format($value, 6); } else { diff --git a/phpstan.dist.baseline.neon b/phpstan.dist.baseline.neon index ecf48a0b04e..d2b5a0b57eb 100644 --- a/phpstan.dist.baseline.neon +++ b/phpstan.dist.baseline.neon @@ -15244,3 +15244,103 @@ parameters: message: "#^Variable \\$relativeFilename might not be defined\\.$#" count: 4 path: get.php + + - + message: "#^Comparison operation \"\\>\\=\" between int\\<0, max\\> and 0 is always true\\.$#" + count: 1 + path: lib/Mage/Archive.php + + - + message: "#^Offset 'basename' on array\\{dirname\\?\\: string, basename\\: string, extension\\?\\: string, filename\\: string\\} on left side of \\?\\? always exists and is not nullable\\.$#" + count: 1 + path: lib/Mage/Archive/Helper/File.php + + - + message: "#^Method Mage_Backup_Filesystem\\:\\:create\\(\\) should return bool but return statement is missing\\.$#" + count: 1 + path: lib/Mage/Backup/Filesystem.php + + - + message: "#^Method Mage_Backup_Filesystem\\:\\:rollback\\(\\) should return bool but return statement is missing\\.$#" + count: 1 + path: lib/Mage/Backup/Filesystem.php + + - + message: "#^Call to an undefined method Mage_Backup_Interface\\:\\:getBackupFilename\\(\\)\\.$#" + count: 1 + path: lib/Mage/Backup/Media.php + + - + message: "#^Call to an undefined method Mage_Backup_Interface\\:\\:getBackupPath\\(\\)\\.$#" + count: 1 + path: lib/Mage/Backup/Snapshot.php + + - + message: "#^Negated boolean expression is always true\\.$#" + count: 1 + path: lib/Mage/Cache/Backend/File.php + + - + message: "#^Function mysqli_connect_errno invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: lib/Mage/DB/Mysqli.php + + - + message: "#^Function mysqli_connect_error invoked with 1 parameter, 0 required\\.$#" + count: 1 + path: lib/Mage/DB/Mysqli.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 2 + path: lib/Mage/HTTP/Client/Curl.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: lib/Mage/HTTP/Client/Curl.php + + - + message: "#^Undefined variable\\: \\$data$#" + count: 1 + path: lib/Mage/HTTP/Client/Curl.php + + - + message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" + count: 2 + path: lib/Mage/HTTP/Client/Socket.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 2 + path: lib/Mage/HTTP/Client/Socket.php + + - + message: "#^Property Mage_HTTP_Client_Socket\\:\\:\\$_postFields is never read, only written\\.$#" + count: 1 + path: lib/Mage/HTTP/Client/Socket.php + + - + message: "#^Property Mage_HTTP_Client_Socket\\:\\:\\$_redirectCount is never read, only written\\.$#" + count: 1 + path: lib/Mage/HTTP/Client/Socket.php + + - + message: "#^Empty array passed to foreach\\.$#" + count: 1 + path: lib/Mage/System/Ftp.php + + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: lib/Mage/Xml/Generator.php + + - + message: "#^Argument of an invalid type Zend_Db_Statement_Interface supplied for foreach, only iterables are supported\\.$#" + count: 1 + path: lib/Magento/Db/Object/Trigger.php + + - + message: "#^Ternary operator condition is always true\\.$#" + count: 2 + path: lib/Magento/Profiler/Output/Firebug.php diff --git a/phpstan.dist.neon b/phpstan.dist.neon index 96b3b04d255..18abfef71f9 100644 --- a/phpstan.dist.neon +++ b/phpstan.dist.neon @@ -5,74 +5,74 @@ parameters: phpVersion: 80000 # PHP 8.0 magentoRootPath: %currentWorkingDirectory% paths: - - %currentWorkingDirectory%/api.php - - %currentWorkingDirectory%/cron.php - - %currentWorkingDirectory%/get.php - - %currentWorkingDirectory%/index.php - - %currentWorkingDirectory%/install.php - - %currentWorkingDirectory%/app/Mage.php - - %currentWorkingDirectory%/app/code/core/Mage + - api.php + - cron.php + - get.php + - index.php + - install.php + - app/Mage.php + - app/code/core/Mage + - lib/Mage + - lib/Magento excludePaths: #todo DOCblocks - - %currentWorkingDirectory%/app/code/core/Mage/Usa - - %currentWorkingDirectory%/app/code/core/Mage/Weee - - %currentWorkingDirectory%/lib/Mage - - %currentWorkingDirectory%/lib/Magento - - %currentWorkingDirectory%/lib/Varien + - app/code/core/Mage/Usa + - app/code/core/Mage/Weee + - lib/Varien + + # todo check + - app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php + - app/code/core/Mage/Weee/Model/Total/Quote/Weee.php #incompatible interfaces - - */app/code/core/Mage/Admin/Model/Acl/Assert/Ip.php - - */app/code/core/Mage/Admin/Model/Acl/Assert/Time.php - - */app/code/core/Mage/Api/Model/Acl/Assert/Ip.php - - */app/code/core/Mage/Api/Model/Acl/Assert/Time.php - - */app/code/core/Mage/Adminhtml/Block/Widget/Grid/Block.php - - */app/code/core/Mage/Core/Model/Mysql4/Design/Theme/Collection.php - - */lib/Varien/Directory/Collection.php - - */lib/Varien/Directory/Factory.php - - */lib/Varien/File/Object.php + - app/code/core/Mage/Admin/Model/Acl/Assert/Ip.php + - app/code/core/Mage/Admin/Model/Acl/Assert/Time.php + - app/code/core/Mage/Api/Model/Acl/Assert/Ip.php + - app/code/core/Mage/Api/Model/Acl/Assert/Time.php + - app/code/core/Mage/Adminhtml/Block/Widget/Grid/Block.php + - app/code/core/Mage/Core/Model/Mysql4/Design/Theme/Collection.php + - lib/Varien/Directory/Collection.php + - lib/Varien/Directory/Factory.php + - lib/Varien/File/Object.php # deprecated _getHelper() - - */app/code/core/Mage/Adminhtml/Controller/Rss/Abstract.php - - */app/code/core/Mage/Adminhtml/controllers/Rss/OrderController.php - - */app/code/core/Mage/Adminhtml/controllers/Rss/CatalogController.php + - app/code/core/Mage/Adminhtml/Controller/Rss/Abstract.php + - app/code/core/Mage/Adminhtml/controllers/Rss/OrderController.php + - app/code/core/Mage/Adminhtml/controllers/Rss/CatalogController.php # contains 1 abstract method and must therefore be declared abstract or implement the remaining methods - - */app/code/core/Mage/Dataflow/Model/Session/Adapter/Http.php - - */app/code/core/Mage/Dataflow/Model/Convert/Iterator/Http.php - - */app/code/core/Mage/Dataflow/Model/Convert/Iterator/File/Csv.php - - */lib/Varien/Convert/Validator/Column.php + - app/code/core/Mage/Dataflow/Model/Session/Adapter/Http.php + - app/code/core/Mage/Dataflow/Model/Convert/Iterator/Http.php + - app/code/core/Mage/Dataflow/Model/Convert/Iterator/File/Csv.php + - lib/Varien/Convert/Validator/Column.php # Cannot declare class Varien_Date, because the name is already in use - - */app/code/core/Mage/Catalog/Model/Product/Option/Type/Date.php + - app/code/core/Mage/Catalog/Model/Product/Option/Type/Date.php # Cannot declare class XMLParser, because the name is already in use - - */app/code/core/Mage/Centinel/Model/Api.php - - */app/code/core/Mage/Centinel/Model/Api/Client.php + - app/code/core/Mage/Centinel/Model/Api.php + - app/code/core/Mage/Centinel/Model/Api/Client.php # Class phpseclib\Net\SSH2 not found. - - */app/code/core/Mage/Paypal/Model/Report/Settlement.php - - */lib/Varien/Io/Sftp.php + - app/code/core/Mage/Paypal/Model/Report/Settlement.php + - lib/Varien/Io/Sftp.php # Class backup/db was not found while trying to analyse it - - */app/code/core/Mage/Adminhtml/controllers/System/BackupController.php + - app/code/core/Mage/Adminhtml/controllers/System/BackupController.php # Dataflow/Model/Convert/Iterator.php - - */app/code/core/Mage/Dataflow/Model/Convert/Iterator.php + - app/code/core/Mage/Dataflow/Model/Convert/Iterator.php # Too much noise from "Variable $this might not be defined" - - */app/code/core/*/*/data/* - - */app/code/core/*/*/sql/* + - app/code/core/*/*/data/* + - app/code/core/*/*/sql/* # requires Mycrypt - - */lib/Magento/Crypt.php - - */lib/Varien/Crypt/Mcrypt.php + - lib/Magento/Crypt.php + - lib/Varien/Crypt/Mcrypt.php # Instantiated class not found - - */lib/Varien/Image/Adapter.php - - # todo check - - */app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php - - */app/code/core/Mage/Weee/Model/Total/Quote/Weee.php + - lib/Varien/Image/Adapter.php level: 5 checkFunctionNameCase: true checkInternalClassCaseSensitivity: true