Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Governance] Token Factory #5

Closed
mktcode opened this issue Mar 16, 2021 · 0 comments
Closed

[Governance] Token Factory #5

mktcode opened this issue Mar 16, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mktcode
Copy link
Contributor

mktcode commented Mar 16, 2021

Concept: https://octobay.github.io/docs/GOVERNANCE.html
UI Mockups: https://www.figma.com/proto/AzJ6BbBetEwtD6h6p8q1uM/Octobay-Governance-UI?scaling=scale-down

Some inspiration:
https://github.com/Giveth/minime
https://github.com/LibertyPie/Governance/tree/main/contracts

The token factory should inherit from the OctobayStorage, so that only the latest version of the Octobay main contract can use it. This is also where oracle checks are performed, so the token factory really only needs a single function (createToken(string _name, string _symbol)) where it uses the token template (#4) to launch new tokens.

Also appropriate events must be emitted so that we can index newly created tokens in our subgraph.

@mktcode mktcode added enhancement New feature or request help wanted Extra attention is needed labels Mar 16, 2021
@mktcode mktcode added this to the cl-hackathon milestone Mar 16, 2021
@mktcode mktcode changed the title Governance Token Factory [Governance] Token Factory Mar 16, 2021
@mktcode mktcode closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant