Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: stdcm: times and durations (rounded?) leads to inconsistent display of stop times in summary #10660

Open
bougue-pe opened this issue Feb 4, 2025 · 0 comments
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug

Comments

@bougue-pe
Copy link
Contributor

bougue-pe commented Feb 4, 2025

What happened?

In STDCM, it's possible to obtain inconsistent time/duration values : arrival at stop is 9:13, departure from stop 9:19 and duration is 7 min.

What did you expect to happen?

I expected the 3 values to be consistent.

Probably:

  • on one hand decide if/how to round arrival/departure times (relates to Departure and arrival times are rounded down in the train list #9179 too?):
    • precise to the second (no rounding)
    • closest
    • floor
    • ... ceiling looks weird IMO
  • on the other hand compute stop duration to have a consistent display:
    • precise to the second (no rounding)
    • use the rounded arrival/departure time values for a duration rounded to the minute

We may as well assume to have inconsistent values (if all is rounded to the closest, it can happen), and maybe just precise exact values at hover?
Example (did not check exact values in provided case): arrival 9:12:35, departure 9:19:25 ⇾ duration 6:50

How can we reproduce it (as minimally and precisely as possible)?

On STDCM, when playing the test by hand, at the step 24 an inconsistent display of times/durations was obtained, probably caused by rounding.

Image

On which environments the bug occurs?

Recette (SNCF), Production (SNCF)

On which browser the bug occurs?

Firefox

OSRD version (top right corner Account button > Informations)

v0.3.10 c9066aa

@bougue-pe bougue-pe added area:front Work on Standard OSRD Interface modules kind:bug Something isn't working severity:minor Minor severity bug labels Feb 4, 2025
@Maymanaf Maymanaf added the module:stdcm Short-Term DCM label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug
Projects
None yet
Development

No branches or pull requests

2 participants