Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

longitudinal section get out of frame #4312

Closed
loic-hamelin opened this issue Jun 8, 2023 · 7 comments · Fixed by #5767
Closed

longitudinal section get out of frame #4312

loic-hamelin opened this issue Jun 8, 2023 · 7 comments · Fixed by #5767
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:minor Minor severity bug

Comments

@loic-hamelin
Copy link
Contributor

loic-hamelin commented Jun 8, 2023

What happened?

image

What did you expect to happen?

The longitudinal section (red line) must stay in the frame

How can we reproduce it (as minimally and precisely as possible)?

Create a train and see the gradient, radius and longitudinal section frame

What operating system, browser and environment are you using?

  • Browser: Firefox v113
  • OS: Ventura
  • Env: Dev

OSRD version (top right corner Account button > Informations)

Editoast e548180 Core e548180 API e548180 Front e548180

@loic-hamelin loic-hamelin added the kind:bug Something isn't working label Jun 8, 2023
@nicolaswurtz nicolaswurtz added difficulty:good first issue Good for newcomers area:front Work on Standard OSRD Interface modules severity:minor Minor severity bug module:operational-studies Multi-train simulation with structured studies management labels Jun 8, 2023
@axrolld axrolld assigned RomainValls and unassigned nicolaswurtz Oct 24, 2023
@axrolld
Copy link
Contributor

axrolld commented Oct 24, 2023

May I suggest a fix for this bug, that would result in an enhancement of this graph until we start using the new component :

There a 3 data represented on this graph, each one with its own unit :

  • slopes (m/km)
  • curvatures (m, i guess ?) -> The unit isn't clear cause only the slopes unit is displayed
  • relative altitude difference (m) -> Same, the unit isn't visible)

In order to fix the scale problem and start fixing the invisible units problem i suggest first creating a second axis to the right of the graph, with the relative altitude difference in meters. This would not fix the curvatures but that could be another issue.

This suggestion would result in the following acceptance criterias :

  • A second axis has been created to the right of the graph, with unit in meters
  • The relative altitude curve and its relative axis (the one to the right) are auto-scaled so that the curve fits entirely

@SharglutDev
Copy link
Contributor

@axrolld Should we scale to the right the positive numbers so they can be aligned with the negative numbers ?

Capture d’écran 2023-12-07 à 14 36 11

@axrolld
Copy link
Contributor

axrolld commented Dec 7, 2023

I think that would make sense yes

@axrolld axrolld removed the difficulty:good first issue Good for newcomers label Dec 8, 2023
@axrolld
Copy link
Contributor

axrolld commented Dec 8, 2023

Removed the good first issue label because this was no piece of cake !

@axrolld
Copy link
Contributor

axrolld commented Jan 11, 2024

Tried it on dev, it works well on the first train of the list

Image

But not on other trains that don't have the same path :

Image

@axrolld
Copy link
Contributor

axrolld commented Jan 11, 2024

Also, tiny detail but the unit m should be rotated by 90° to match the m/km/h display :

Image

@clarani
Copy link
Contributor

clarani commented Jul 17, 2024

Not relevant anymore, opened a new issue #8095

@clarani clarani closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:minor Minor severity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants