Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion detail component refactoring #4023

Closed
bastianjoel opened this issue Aug 14, 2024 · 0 comments · Fixed by #4024
Closed

Motion detail component refactoring #4023

bastianjoel opened this issue Aug 14, 2024 · 0 comments · Fixed by #4024
Assignees
Milestone

Comments

@bastianjoel
Copy link
Member

bastianjoel commented Aug 14, 2024

In preparation for #3529 the motion components should be refactored.

Mainly the following things should be done:

  1. Move create/edit form into its own component
  2. Simplify control flow in templates
  3. Change change detection strategy to OnPush if possible with minor changes
  4. Replace repo calls with direct view model observable calls as of Fix list of speakers names not displayed #3993 if reasonable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant