Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - improve matches graph #54

Closed
Kalo0m opened this issue Mar 2, 2023 · 9 comments
Closed

Feature request - improve matches graph #54

Kalo0m opened this issue Mar 2, 2023 · 9 comments

Comments

@Kalo0m
Copy link
Contributor

Kalo0m commented Mar 2, 2023

Hi guys,

Firstly thank you all for you amazing work. I would like to have your thoughts on a new feature (afaik not available for now).

I have a list of ten images and I know the order of them, it would be nice to pass this order in order to override confidence_threshold and get the right graph. Of course it would be an option.

Example: I have 3 photos (A, B and C) and I know the exact order (B --> C --> A). instead of letting the package find the order and maybe be wrong (for example by rejecting A of the result graph), I could pass the graph below as an option to bypass the graph generation.

graph matches_graph{
"B" -- "C"
"C" -- "A"
}

Sorry if I'm not clear, I would like to contribute so what do you think ? Do you have any suggestions ?

@lukasalexanderweber
Copy link
Member

I have good news for you: It's already a feature.

stitch b.jpg c.jpg a.jpg --range_width 1 --confidence_threshold 0

should do the trick. See also #14

@lukasalexanderweber
Copy link
Member

I admit that it is not well documented, maybe we should include it in the stitching_tutorial

@Kalo0m
Copy link
Contributor Author

Kalo0m commented Mar 2, 2023

Nice! I will take a look thanks a lot

@Kalo0m
Copy link
Contributor Author

Kalo0m commented Mar 2, 2023

you can also explain what's range_width and what is its impact

@lukasalexanderweber
Copy link
Member

setting it to 1 [...] force it to only consider adjacent pairs (e.g. pair 1-2 would have a confidence but pair 1-3 would not)

Setting it to 1 basically just means that that it only looks for matches in images directly to its left or right. 2 would mean 2 images left or right...

All based on the order of the images passed into Stitcher.stitch()

@Kalo0m
Copy link
Contributor Author

Kalo0m commented Mar 2, 2023

And another question, (idk if it's the right place) can the generated image be a spherical photo (in order to put it in a 360 visualizer)?

@lukasalexanderweber
Copy link
Member

at least there is a spherical warper

@phamkhactu
Copy link

phamkhactu commented Oct 17, 2023

stitch b.jpg c.jpg a.jpg --range_width 1 --confidence_threshold 0

Hi @lukasalexanderweber, @Kalo0m

Suppose that I have 5 images: "A, B, C, D, E"

I know matches_graph as below:

A --> B 
A --> D
B --> C
B --> D
D --> E 

As you suggestion I followed in tutorial

I see that, maybe matches_graph is matches_graph_dot_file in Subset parameters ?

Subsetter(confidence_threshold=1, matches_graph_dot_file=None)

I saw in matches_graph have [label="Nm=68, Ni=19, C=0.669014"]. What is the master if I don't have label, Ni, C parameters? And if I use fastest function

 panorama = stitcher.stitch(weid_imgs)

as you summary, Can I put matches_graph for creating adjacent panorama as I expect?

@lukasalexanderweber
Copy link
Member

please use the discussions for questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants