Why are we not using bootstrap > 3.1.1? #379

Martii · 2014-10-20T20:48:41Z

Just for grins I updated bootstrap dev locally to 3.2.0 and it appears in a quick scan to be okay to use e.g. my normal testings it appears to be okay... not fully tested though.

This question is primarily directed towards @Zren

Martii · 2014-10-20T20:51:26Z

I also haven't updated bootswatch to 3.2.0 which I assume is needed to match at some point with boostrap?

Zren · 2014-10-20T23:36:49Z

Reasons not to:

Effort spent merging requires re familiarizing myself with bootswatch.

Reasons to:

Fix bugs no one has mentioned (that are bootstraps fault).
Maybe get new css rules/js components.
Be up to date.

There's really not much I can see worth mentioning in Bootstrap's changelog. Similarly for Bootswatch's CSS changes mentioned in #223.

Also, you shouldn't be editing bootstrap-custom.css by itself. It's a compiled file.
https://github.com/OpenUserJs/OpenUserJS.org/commits/master/public/css/bootstrap-custom.css

Zren · 2014-10-20T23:41:21Z

And the only new feature we might use is

#12204: Visibility and hidden classes for block, inline-block, and inline elements.

Which we already solved here.

Martii · 2014-10-20T23:44:24Z

Also, you shouldn't be editing bootstrap-custom.css by itself. It's a compiled file.

Interesting... although #223 may supersede this ... basically the target objective will be to load their bootstrap.css and cascade with our changes in our own file and referencing both in the views I believe when 3.2.0 is implemented... this will solve the just recently notified that anyone shouldn't be editing the bootstrap-custom.css.

Martii · 2014-11-18T07:56:06Z

Any significant changes in 3.3.1?

Zren · 2014-11-18T08:01:35Z

Do we need to upgrade you mean? No. This will be the same answer for every new version until a bug requires us to update or a new feature is desired.

Martii · 2014-11-18T08:03:23Z

This needs to stay open.

* `z-index` was the culprit for previously mentioned modal failure * Watchpoint for *bootstrap* 3.1.1 changes to 3.3.1 ... if necessary will swap out entire modal sections of CSS with upstream as they do work and are more compact but reserving that task for OpenUserJS#249 Closes OpenUserJS#379

Martii · 2015-01-15T21:44:11Z

@Zren
I would appreciate you pointing me to the configuration file that you used for bootstrap 3.1.1 otherwise next week I will begin reverse engineering it and generating one for OUJS. Thanks.

Zren · 2015-01-15T22:23:25Z

All manual changes to /public/css/bootstrap-custom.css need to be either moved to common.css or applied in the update.
https://github.com/OpenUserJs/OpenUserJS.org/commits/master/public/css/bootstrap-custom.css

As for the configuration:
#223
Zren/bootswatch-OpenUserJS.org@84dd4c6...theme

The changes to bootswatch are too many to list on github (mostly because there's 20 themes it's based off of.
thomaspark/bootswatch@Zren:theme...thomaspark:gh-pages

Probably best to pull away from bootswatch as there's so much noise in the repo for the other themes. The stuff we'll punch into the bootstrap customizer in all in the variables.less file. The extra junk is in the bootswatch.less file.

Did the variables stuff: https://gist.github.com/anonymous/03a4640ed537c1b0c92c
http://getbootstrap.com/customize/?id=03a4640ed537c1b0c92c

* Not our CSS interfering * Would appear that current *bootstrap-markdown* and current *bootstrap* aren't playing nice with `collapse`. e.g. comment reply box shows however it immediately closes itself. I have seen this behavior before a few times but usually a browser restart handled it... not this time. *bootstrap* 3.2.0, 3.3.0 and 3.3.1 all exhibit this behavior * Leaving `z-index` fix in as 3.1.1 appears not to need this from testing. Refs OpenUserJS#540 and OpenUserJS#379

* Not our CSS interfering * jQuery event listeners tested... okay * Would appear that current *bootstrap-markdown* and current *bootstrap* aren't playing nice with `collapse`. e.g. comment reply box shows however it immediately closes itself. I have seen this behavior before a few times but usually a browser restart handled it... not this time. *bootstrap* 3.2.0, 3.3.0 and 3.3.1 all exhibit this behavior * Leaving `z-index` fix in as 3.1.1 appears not to need this from testing. Refs OpenUserJS#540 and OpenUserJS#379

Martii · 2015-01-16T03:33:30Z

Reopening due to #541

Will work on this next week a bit.

Thank you Zren for the linkage.

Martii · 2015-01-20T09:54:43Z

@Zren

A few questions come to mind to help me understand bootstrap a little better

All manual changes to...

Including your changes or just mine?

Probably best to pull away from bootswatch...

Using the default theme of bootstrap itself there is no coloration for our current site colors. Is that included in your gist? If so how exactly are we supposed to read in the JSON? (Remember grunt is currently way back on the burner and manual understanding is a must here... I've been twiddling with less and "myVars" and there's some reference to JSON with this link)

General question of ... Why is there bootstrap.css and bootstrap-theme.css in the downloaded zip file from http://getbootstrap.com/customize/?id=03a4640ed537c1b0c92c ? (This is also present in the dist folder of bootstrap... I understand the website whittles down what we don't use but when are we supposed to apply our own theme? common.css of course is loaded afterwards so I might plan on moving Squada One there at some point)

Zren · 2015-01-20T10:11:22Z

Including your changes or just mine?

Yours. All of mine are from modifying the .less files and not the .css file itself.

General question of why is there bootstrap.css and bootstrap-theme.css

Because you need to include both bootstrap.css and bootstrap-theme.css. Bootswatch combined the two files into a single file. The first is the default bootstrap file, the second is a file that overrides all the previous rules with the different variable values. You'll also need to put https://github.com/Zren/bootswatch-OpenUserJS.org/blob/theme/custom/bootswatch.less into a 3rd file or dump it into the top of common.css.

* Use *less-middleware* for compiling now until *express-minify* can be retested and possibly more RFEs. Methodology of *express-minify* has been tested to be cleaner with caching... but there's a new update and will have to run all those tests again. Project tree structure should be compatible with either one. Applies to OpenUserJS#249 and should be near parallel change for OpenUserJS#379

* Tell compiler not to compress. We handle this elsewhere. Fix for dbg mode too. * In case someone tries to access **any** of these .less files in dev/dbg add **all** to `.gitignore`. Finish coding shock. ;) * Scoot/modify the comments in `oujs.less` file to indicate where things should usually go * Create an "unstaged" area in `oujs-bootswatch.less` for unstaged/unincorporated CSS into the variables/mixin stream... e.g. move my fixes to the bottom. If we stick with bootstrap these should be added to the updates. Bootswatch may at some point twiddle with these values so putting at end forces them to happen with standard cascading in style sheets Applies to OpenUserJS#249 and should be near parallel change for OpenUserJS#379

* *bootstrap* notes ** Don't set initial height... this is what was making it open/close automatically... needed in latest *bootstrap* ** `floor` and adjust reminders to top/bottom padding only otherwise viewport horizontal scrollbar appears with this *bootstrap* ... Related to OpenUserJS#484 and starting at OpenUserJS#568 ** Remove unused classes at `/user/add/scripts` so it doesn't color differently... e.g. this is probably a bug that was fixed in latest *bootstrap* as well as possible improper usage in our code. * *mongoose* update * *sanitize-html* update Closes OpenUserJS#379

* Fixes a blowout of the design layout in the footer with extremely small viewport * Removed overloaded rule in `.../common.css` due to deprecation... See [here](http://getbootstrap.com/css/#responsive-utilities-classes)... post OpenUserJS#379 * Manually change all grepped `visible-` to appropriate matches

Martii added question A question has been encountered by anyone and has remained unanswered until cleared. team biz This is similar to a meta discussion. labels Oct 20, 2014

Martii changed the title ~~Why are we not using boostrap 3.2.0~~ Why are we not using boostrap 3.2.0? Oct 20, 2014

Martii mentioned this issue Oct 21, 2014

Add the bootswatch fork to OpenUserJS Organization #223

Closed

Zren closed this as completed Nov 18, 2014

Martii reopened this Nov 18, 2014

Martii changed the title ~~Why are we not using boostrap 3.2.0?~~ Why are we not using boostrap > 3.1.1? Nov 23, 2014

Martii mentioned this issue Jan 15, 2015

Update *bootstrap* dep to latest #540

Merged

Martii closed this as completed in #540 Jan 15, 2015

Martii removed the team biz This is similar to a meta discussion. label Jan 15, 2015

Martii added this to the #249 milestone Jan 15, 2015

Martii added question A question has been encountered by anyone and has remained unanswered until cleared. and removed question A question has been encountered by anyone and has remained unanswered until cleared. labels Jan 15, 2015

Martii added needs mitigation Needs additional followup. and removed question A question has been encountered by anyone and has remained unanswered until cleared. labels Jan 15, 2015

Martii mentioned this issue Jan 16, 2015

Revert *bootstrap* dep update #541

Merged

Martii reopened this Jan 16, 2015

Martii removed the needs mitigation Needs additional followup. label Jan 16, 2015

Martii mentioned this issue Jan 20, 2015

Compile, parse, and cache *bootstrap* 3.1.1 #544

Merged

Martii changed the title ~~Why are we not using boostrap > 3.1.1?~~ Why are we not using bootstrap > 3.1.1? Feb 7, 2015

Martii self-assigned this Feb 7, 2015

Martii added CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration. labels Feb 7, 2015

Martii mentioned this issue Feb 7, 2015

Some dep updates #571

Merged

Martii closed this as completed in #571 Feb 7, 2015

Martii removed their assignment Feb 8, 2015

Martii mentioned this issue Feb 9, 2015

Use short OUJS name in footer with \*-xs-\* modes #579

Merged

Martii mentioned this issue May 29, 2015

Nodejitsu shutting down. Modifications for new host. #635

Merged

OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Why are we not using bootstrap > 3.1.1? #379

Why are we not using bootstrap > 3.1.1? #379

Martii commented Oct 20, 2014

Martii commented Oct 20, 2014

Zren commented Oct 20, 2014

Zren commented Oct 20, 2014

Martii commented Oct 20, 2014

Martii commented Nov 18, 2014

Zren commented Nov 18, 2014

Martii commented Nov 18, 2014

Martii commented Jan 15, 2015

Zren commented Jan 15, 2015

Martii commented Jan 16, 2015

Martii commented Jan 20, 2015

Zren commented Jan 20, 2015

Why are we not using bootstrap > 3.1.1? #379

Why are we not using bootstrap > 3.1.1? #379

Comments

Martii commented Oct 20, 2014

Martii commented Oct 20, 2014

Zren commented Oct 20, 2014

Zren commented Oct 20, 2014

Martii commented Oct 20, 2014

Martii commented Nov 18, 2014

Zren commented Nov 18, 2014

Martii commented Nov 18, 2014

Martii commented Jan 15, 2015

Zren commented Jan 15, 2015

Martii commented Jan 16, 2015

Martii commented Jan 20, 2015

Zren commented Jan 20, 2015