Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed items aren't fully searchable #490

Open
Martii opened this issue Dec 8, 2014 · 3 comments
Open

Removed items aren't fully searchable #490

Martii opened this issue Dec 8, 2014 · 3 comments
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. tracking upstream Waiting, watching, wanting.

Comments

@Martii
Copy link
Member

Martii commented Dec 8, 2014

EDIT: Isolated searches are now not searchable because we needed a general search

As mentioned in #489 the removed items fail to search on at the very least a Remover name.

Some dev test points:

One possible resolution suggested from @jerone with:

A found ... reason: the column Item is not a searchable property. The column Type is for example a searchable column (http://localhost:8080/mod/removed?q=user)

EDIT:
Searching should try to include more columns not just ones that are linked.

Keep in mind #526
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Dec 8, 2014
@Martii Martii changed the title Removed items aren't searchable Removed items aren't fully searchable Dec 8, 2014
This was referenced Jan 11, 2015
Closed
Closed
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jun 29, 2015
Add QSP for sort parm q urls if present
5411de3 
* Added for group list sorting
* Added for script list sorting
* Added for user list sorting

* Not applied to graveyard since that is OpenUserJS#490 ... remainder of scripts/libraries/users "should" be okay.

See also:
* Initial report at https://openuserjs.org/discuss/faulty_search_order_by_...
@Martii Martii mentioned this issue Jun 29, 2015
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Aug 4, 2015
Patch for searching remover and reason in graveyard
32a27af 
* Unable to find documentation on the wildcard at this time but appears that it doesn't work... closest match is an issue on *mongoose* at 3213 ... nothing I've tried works there with `{ type : Object, index : true }` or other type ... this probably isn't the final solution and another QSP would be useful to limit scope and perhaps another of exclusion of scope... but these are all encompassing searches for now.
* Those stray commas again
* Change casing on `WATCHPOINT` back to `NOTE: Watchpoint` for grep'ability

Applies to post fix OpenUserJS#696, patch for OpenUserJS#490, and solution needed in OpenUserJS#485
@Martii Martii mentioned this issue Aug 4, 2015
Merged
@Martii
Copy link
Member Author

Martii commented Aug 4, 2015

This issue is still open because it would nice to have another QSP, maybe model, that would just return results from the items from the model removed and ignore everything else including reason... like it was doing before #699 (shallow search before that in #697) ... but we still need a generalized search (now) which is why just a q= is general... for now.

@Martii
Copy link
Member Author

Martii commented Aug 4, 2015

And perhaps a "not" flag QSP... to invert the search.

depth with shallow vs deep vs surface ?? ... script searching is quite "deep" right now since it goes across a lot of things such as in the model using name, author, about, meta.include, etc.

@Martii Martii self-assigned this Aug 5, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Aug 5, 2015
Reestablish the model filters
c431410 
* This is about the medium average point between methodologies of Zren, Jerone, SizzleMcTwizzle and myself that can managed at the moment... I tinkered with naming the QSP `filterBy`... Item, Reason, Removed By, and Date will never be filtered imho so I ended up with a merge of `byModel`.
* Fixed a bug on `exports.`...
* Renamed the column from `Type` to `Model` since that's probably what is going to be in here... although `strategy` model probably won't but the `orderBy` QSP is already using `model`

Applies to OpenUserJS#490
@Martii Martii mentioned this issue Aug 5, 2015
Merged
@Martii Martii removed their assignment Aug 5, 2015
@Martii Martii added the tracking upstream Waiting, watching, wanting. label Aug 5, 2015
@Martii
Copy link
Member Author

Martii commented Aug 5, 2015

Added tracking upstream label due to content.* not working currently.... and it would be nice to find the documentation for this. I never did find the syntax reference for it.

Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Aug 7, 2015
A findOrDefaultIfNull issue
20f28d5 
* Rename existing query filter chained condition for a DB specific use case
* Create a new query filter chain specific for using defaults
* Singular the search placeholder for removed items in whatever model

Closes OpenUserJS#701 and post OpenUserJS#490 and OpenUserJS#700 fix
@Martii Martii mentioned this issue Aug 7, 2015
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Aug 7, 2015
Add an active class to the filters
afc6251 
* More visible distinction on filtered models in removed items

Applies to OpenUserJS#490
@Martii Martii mentioned this issue Aug 7, 2015
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Aug 7, 2015
Some more misc visual effects
adcb73d 
* Don't select Clear Filter at removed items in case someone gets clever and modifies the url to a non-existent model filter
* Give the Clear Filter at removed items a little coloring just for informational purposes with an applicable *bootstrap* class
* Match some the *font-awesome* icons in a few other places in xs views and normal views ... using singular icons always but text can be plural if applicable
* @sizzlemctwizzle ... Would like to turn rating into the `fa-heartbeat` to indicate the pulse however that is currently blocking assigned in OpenUserJS#262 as a vote thing. Would be a better distinction between installs and that I believe.

Applies to OpenUserJS#490
@Martii Martii mentioned this issue Aug 7, 2015
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Aug 7, 2015
Vote icon change to match current site layout
c200425 
* Added vote to FortAwesome/Font-Awesome#2301 ... would be a great addition if released. :)
* Probably going to take a break from this section for a while

Applies to OpenUserJS#490
@Martii Martii mentioned this issue Aug 7, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. tracking upstream Waiting, watching, wanting.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Martii