Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 404 status code for Fallback routes #121

Merged

Conversation

Martii
Copy link
Member

@Martii Martii commented May 31, 2014

  • Useful for determining what's potentially broken during testing
  • Automatic editor white-space cleanup

* Useful for determining what's potentially broken during testing
* Automatic editor white-space cleanup
@Martii
Copy link
Member Author

Martii commented May 31, 2014

This:

http://localhost:8080/groupies

GET /groupies HTTP/1.1
Host: localhost:8080
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate
DNT: 1
Connection: keep-alive
Pragma: no-cache
Cache-Control: no-cache

HTTP/1.1 404 Not Found
X-Powered-By: Express
Content-Type: text/html; charset=utf-8
Set-Cookie: connect.sid=*clipped*; Path=/; HttpOnly
Vary: Accept-Encoding
Content-Encoding: gzip
Date: Sat, 31 May 2014 10:12:14 GMT
Connection: keep-alive
Transfer-Encoding: chunked

instead of:

https://openuserjs.org/groupies

GET /groupies HTTP/1.1
Host: openuserjs.org
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate
DNT: 1
Cookie: connect.sid=*clipped*
Connection: keep-alive

HTTP/1.1 200 OK
X-Powered-By: Express
Strict-Transport-Security: max-age=8640000; includeSubDomains
Content-Type: text/html; charset=utf-8
Vary: Accept-Encoding
Content-Encoding: gzip
Date: Sat, 31 May 2014 10:19:01 GMT
Connection: keep-alive
Transfer-Encoding: chunked

sizzlemctwizzle added a commit that referenced this pull request Jun 1, 2014
@sizzlemctwizzle sizzlemctwizzle merged commit dddc18d into OpenUserJS:master Jun 1, 2014
@Martii Martii deleted the use404statusCodeForFallbackRoute branch June 1, 2014 04:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Development

Successfully merging this pull request may close these issues.

2 participants