Emphasizing the Issue and PR process #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies to OpenUserJS#60 and OpenUserJS#167
added 2 commits
July 2, 2014 17:22
Applies to OpenUserJS#240, OpenUserJS#167 and OpenUserJS#60
* Applies to OpenUserJS#240, OpenUserJS#167 and OpenUserJS#60
Applies to OpenUserJS#240, OpenUserJS#167 and OpenUserJS#60
|
|
||
| The following is a brief list of **some** of the labels used on the project and is used to establish teamwork. Not everyone has permission to set these and usually will be set by someone unless expressly prohibited: | ||
|
|
||
| ##### BLOCKING |
There was a problem hiding this comment.
"This label means that merging unrelated or non-bugfix PRs will be put on hold until this label has been removed."
No clue. Did I add that? Anyway, I just deleted it.
Aside from my line comments, it looks like you got everything. |
* More descript elaboration * Some spelling corrections.. ran it through a spell checker. * Removed `upstream` label ref and question * Changed `console` to `terminal` since console is more KDE oriented and terminal is more X oriented. e.g. devoid of Window Manager. Applies to OpenUserJS#240, OpenUserJS#167 and OpenUserJS#60
added 3 commits
July 2, 2014 21:41
…used together. * e.g. let the hosting site resolve those. Applies to OpenUserJS#240, OpenUserJS#167, OpenUserJS#116, and OpenUserJS#60
Applies to OpenUserJS#240, OpenUserJS#167, OpenUserJS#116, and OpenUserJS#60
sizzlemctwizzle
added a commit
that referenced
this pull request
Jul 3, 2014
Emphasizing the Issue and PR process
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to #60 and #167
@sizzlemctwizzle
Would you please skim over these additions and see if I missed anything or want something changed? I do have some grammar issues which are good to correct for translators... and I'll get to that in a bit.
I also have no idea what the
upstreamlabel means which is blocking the PR READY label for this... what is it?