Issue #357: unused lib view components #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 22, 2014 15:29
**NOTE**: Possible dependency failure with *mu2*. There appears to be a bug here on parsing... notated in html comment See also: * https://github.com/OpenUserJs/OpenUserJS.org/blob/1b595bb6a986a781fa87f04cc27e31a011b81dbb/controllers/scriptStorage.js#L79 Applies to OpenUserJS#357
Thanks go to @Zren for this. Closes OpenUserJS#357
Martii
added
PR READY
* Use a `–` to denote we know it's not there instead of absent tag. Applies to OpenUserJS#357 and committed in pr OpenUserJS#439
| @@ -2,7 +2,7 @@ | |||
| <thead> | |||
| <tr> | |||
| <th class="text-center"><a href="?orderBy=name&orderDir={{orderDir.name}}{{#librariesOnly}}&library=true{{/librariesOnly}}{{#isFlagged}}&flagged=true{{/isFlagged}}">Name</a></th> | |||
| <th class="text-center td-fit"><a href="?orderBy=installs&orderDir={{orderDir.install}}{{#librariesOnly}}&library=true{{/librariesOnly}}{{#isFlagged}}&flagged=true{{/isFlagged}}">Installs</a></th> | |||
| {{^librariesOnly}}<th class="text-center td-fit"><a href="?orderBy=installs&orderDir={{orderDir.install}}{{#librariesOnly}}&library=true{{/librariesOnly}}{{#isFlagged}}&flagged=true{{/isFlagged}}">Installs</a></th>{{/librariesOnly}} | |||
There was a problem hiding this comment.
The second if-statement for librariesOnly might be redundant here: {{#librariesOnly}}&library=true{{/librariesOnly}}
There was a problem hiding this comment.
It sure looks like it... needed your confirmation on this since you did this portion earlier in the project and I didn't watch much on what you did... thank you. :)
There was a problem hiding this comment.
Actually you did the {{#librariesOnly}}&library=true{{/librariesOnly}} part.
|
@Martii commented on 23 nov. 2014 00:08 CET:
Just one comment to go and then +1 👍 from me. |
jerone
changed the title
jerone
changed the title
Thanks go to @jerone for that catch/verification Applies to OpenUserJS#357 and commited in pr OpenUserJS#439
|
Thanks for the title change... this wide theme .user.js I'm using for GH is starting to stray and I didn't see that... might have to disable that soon or go bug him. |
|
I'm feeling everyone has had a chance to pick this over so in about 10ish minutes or so I'll merge. |
Martii
added a commit
that referenced
this pull request
Nov 23, 2014
Issue #357: unused lib view components merging
Martii
removed
the
PR READY
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Feb 9, 2016
* Set up server to client caching for inline serving of scripts... full manual, direct method e.g. not middleware * Server to DB caching is not in this commit... additional MongoDB item will be needed for Script model to skip redoing minification constantly... will be later. During experimental phase this is probably a good thing to hold off on for a bit anyhow. * Remove minification request stdout message... already enough data on interest. Applies to OpenUserJS#432 and OpenUserJS#439
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Jul 28, 2020
Martii
added a commit
that referenced
this pull request
Jul 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay to go? (the reason why I ask is it's not as critical but is confusing for some... could use a "just do it" but can also perhaps use other input)
Applies to #357 not 383 ughh... apologize for the incorrect naming of the branch... I was looking at both of these during this... still don't have answer for #383 though.