Issue 181 fix some mod searching #491
Conversation
* Apparently flagged true form variable is carried over between tabs/refreshes so remove it when not on a flagged query * Resolve incremental form variable by moving `isFlagged` into conditional * Stray trailing comma in object fix * Remove some dead code * Some STYLEGUIDE.md conformance with missing braces and newlines, and some strict equality test *(still one left in this file but not testing there yet)* * Tested non-flagged routes and checks okay Closes OpenUserJS#181
Martii
added
CODE
Applies to OpenUserJS#181, OpenUserJS#489 and implemented in OpenUserJS#491 See also request at OpenUserJS#181 (comment)
|
This is the bug right here: https://github.com/OpenUserJs/OpenUserJS.org/blob/master/libs/modelQuery.js#L180 We're reusing the same array for every request. We need to copy (probably deepcopy) the default arrays instead of reusing it. |
Correct and you answered your line note question with this. Because I'm still newer to this portion of code it would be useful to have some pointers on where to do a deep copy (clone the initial array) and bring that cloned variable into an isolated and non-reused scope... that would be a refactor not a fix like this PR is. Because time is limited for spending on this issue (just as jerone alluded to when he deassigned himself) with assisting it would keep it in within the time frame that I've allotted. I do have other duties as usual and I'm more inclined to get this patch deployed in the next few hours with any luck and mitigate a new issue with a refactor... See #492 |
Issue 181 fix some mod searching Auto-merge ... confirmation of theory versus test results... this is a fix and generating a new refactor issue.
Martii
removed
the
PR READY
* Very odd boog... dev had `Search Flagged Libraries` and pro had `Search Libraries` until I blanked out dev lib flags... then they matched. Force the text in along with the flag just to be sure. DOM duplication now appears to be related only to the logic issue at OpenUserJS#492 Post fix for OpenUserJS#491
See commit summaries for specifics.
@jerone and @Zren ... how about this?