Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching doesn't remember flagged state #181

Closed
jerone opened this issue Jun 18, 2014 · 10 comments
Closed

Searching doesn't remember flagged state #181

jerone opened this issue Jun 18, 2014 · 10 comments
Labels
bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.

Comments

@jerone
Copy link
Contributor

jerone commented Jun 18, 2014

The searchbar in the moderation page doesn't remember the flagged state, making searching within flagged scripts/libraries/users impossible.
This was referenced Jul 27, 2014
Merged
Merged
@Zren
Copy link
Contributor

Zren commented Sep 2, 2014

Need to add a flagged: true entry into the searchBarFormHiddenVariables somewhere.

@Zren Zren self-assigned this Sep 2, 2014
@jerone
Copy link
Contributor Author

jerone commented Dec 7, 2014

@Zren commented on 2 sep. 2014 20:04 CEST:

Need to add a flagged: true entry into the searchBarFormHiddenVariables somewhere.

@Zren Are you busy with this issue? I would like to take over this issue as I've found a solution...

@jerone jerone unassigned Zren Dec 7, 2014
@jerone
Copy link
Contributor Author

jerone commented Dec 7, 2014

Hmmm, I did NOT unassign you just right now!!! This is probably because you are not a collaborator (?!) anymore.

I'm still going to wait for your answer as you were previously self-assigned.

@Martii
Copy link
Member

Martii commented Dec 7, 2014

Can still make a verbal statement of Assignment (Preferably in BOLD)... I was wondering that too on another issue. I'll try reassigning to Zren but if GH doesn't keep that we'll have to live with it.

@Martii
Copy link
Member

Martii commented Dec 7, 2014

So I've added a "Consultants" group to teams... for lack of better naming... and asked @Zren to join it... it has "read" access... if that works for assignment we can use that... he can always submit PRs though with the specific issue number and issue branch name as outlined in CONTRIBUTING.md... and it's a good idea to put a number sign with the issue number in the commit summary so we see it in the issue.

@jerone jerone mentioned this issue Dec 7, 2014
Closed
@Zren
Copy link
Contributor

Zren commented Dec 7, 2014

Was gonna unassign myself from this one but couldnt. So go ahead. Githubs being weird today. I saw you unassign me from pushdescription right before i posted my comment last night on it and was like wat.

@Martii
Copy link
Member

Martii commented Dec 7, 2014

So that group is not allowing assignment. Just make a statement, preferably in bold, so we all see it for assignment or deassignment for now.

@jerone
Copy link
Contributor Author

jerone commented Dec 7, 2014

@Zren commented on 7 dec. 2014 18:29 CET:

Was gonna unassign myself from this one but couldnt. So go ahead. Githubs being weird today. I saw you unassign me from pushdescription right before i posted my comment last night on it and was like wat.

Thnx! Yeah sorry for that, I don't know what happens.

@jerone jerone self-assigned this Dec 7, 2014
@jerone jerone mentioned this issue Dec 7, 2014
Closed
@Martii
Copy link
Member

Martii commented Dec 7, 2014

The searchbar in the moderation page doesn't remember the flagged state, making searching within flagged scripts/libraries/users impossible.

Pay attention to your "making searching within flagged scripts/libraries/users impossible."... until that is fixered with your PR it isn't ready.

@Martii
Copy link
Member

Martii commented Dec 7, 2014

Would be nice to have the the placeholder attribute reflect the search type too.

@jerone jerone removed their assignment Dec 8, 2014
@Martii Martii added the bug You've guessed it... this means a bug is reported. label Dec 8, 2014
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Dec 8, 2014
Finish off OpenUserJS#489 for searching on some moderation pages
28fad7c 
* Apparently flagged true form variable is carried over between tabs/refreshes so remove it when not on a flagged query
* Resolve incremental form variable by moving `isFlagged` into conditional
* Stray trailing comma in object fix
* Remove some dead code
* Some STYLEGUIDE.md conformance with missing braces and newlines, and some strict equality test *(still one left in this file but not testing there yet)*
* Tested non-flagged routes and checks okay

Closes OpenUserJS#181
@Martii Martii self-assigned this Dec 8, 2014
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Dec 8, 2014
Change placeholder attribute for flagged items
4bcc198 
Applies to OpenUserJS#181, OpenUserJS#489 and implemented in OpenUserJS#491

See also request at OpenUserJS#181 (comment)
@Martii Martii added the needs mitigation Needs additional followup. label Dec 9, 2014
@jerone jerone closed this as completed in 82ef58c Dec 9, 2014
@Martii Martii mentioned this issue Dec 9, 2014
Open
@Martii Martii removed their assignment Dec 9, 2014
@Martii Martii removed the needs mitigation Needs additional followup. label Jan 11, 2015
@Martii Martii mentioned this issue Jan 12, 2015
Closed
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remember flagged state when searching on moderation pages; Fixes #181
3 participants
@jerone @Martii @Zren