Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate shown and linkified @keys #191

Closed
Martii opened this issue Jun 20, 2014 · 1 comment
Closed

Validate shown and linkified @keys #191

Martii opened this issue Jun 20, 2014 · 1 comment
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. security Usually relates to something critical.

Comments

@Martii
Copy link
Member

Martii commented Jun 20, 2014

Need at least scheme URL check validation for @homepageURL and @supportURL... otherwise don't link, don't show and/or do strip. A generic function something described like:

function validateURL(aString, [aProtocol, aProtocol, ...]) {

 // Some tests

  return;
}

... would be nice... or just sanitize it with whatever we end up using for that.

Affected Dependencies:
@Martii Martii mentioned this issue Jun 20, 2014
Merged
@Martii Martii added sooner and removed sooner labels Jun 21, 2014
@Martii Martii changed the title Validate shown and linkified @keys Validate shown and linkified @keys Jun 22, 2014
@Martii
Copy link
Member Author

Martii commented Jun 23, 2014

Since no one took this over the weekend... including a fix in #189 ... closing.

@Martii Martii closed this as completed Jun 23, 2014
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Oct 30, 2017
@Martii
Some misc near parallel UI changes
938527a 
* Change some icons around
* Add a tooltip
* Move default licensing arbitration to view instead of code... allows visual detection

Post OpenUserJS#1204 OpenUserJS#191 Loosely related to OpenUserJS#116, and OpenUserJS#944 via OpenUserJS#970
@Martii Martii mentioned this issue Oct 30, 2017
Merged
Martii added a commit that referenced this issue Oct 30, 2017
@Martii
Some misc near parallel UI changes (#1208)
0318ec5 
* Change some icons around
* Add a tooltip
* Move default licensing arbitration to view instead of code... allows visual detection

Post #1204 #191 Loosely related to #116, and #944 via #970

Auto-merge
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. security Usually relates to something critical.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Martii